Report what an apply changed, cascades included

Abierto
  • ¿Algo no está bien?
#641 1 comentario 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
35/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
csharp, typescript
Área
api, backend

Línea de trabajo

Start with the implementation of apply, the C# Apply path, onAnalysisChanged, and DraftRepository; the issue does not name file paths, so locate these entry points first. Read the linked issues #601 and #628 for context, then inspect how commit snapshots represent cascaded deletes. Done means apply reports links deleted with an analysis on both repositories, with conformance coverage and the earlier DeletedAt preserved.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Part of #601. Follows #628.

Why

The C# repository cascades deletes, and no change set reports a cascade.

  • #628's guard covers this client's edits, but not undo, redo, or re-anchor passes, which don't stage through ChangeBuffer.
  • Not covered: project deletes (#597), and synced commits that land a link deleted (#256).

Proposed direction

apply replies with what the commit actually changed, not what was staged.

  • C#: Harmony records each cascaded record as a snapshot under the commit that caused it, so Apply can read the commit's snapshots and return them.
  • TS: sessions report that reply on onAnalysisChanged in place of the staged changes.
  • DraftRepository: emulates the cascade, so the conformance suite can test both.

Fix along the way: RemoveReference overwrites the DeletedAt of a link that's already deleted. Have it keep the earlier one.

Open questions

  • Snapshots after the commit, or a projected-entity interceptor inside its transaction? The interceptor also sees synced commits, but it reports a whole replay.
  • A project delete's reply lists every record. Cap it the way #593 caps passChanges?

Context

  • A later sync can rewrite what an earlier commit did. #627's revert should recompute it rather than trust an earlier reply.

Done when

  • apply reports the links that an analysis delete took with it, on both repositories.

Drafted by Claude Opus 5.5 (Claude Code); partially human-reviewed.

Lenguaje dominante
TypeScript
Estrellas
2
Forks
0
Merge medio
1 d 1 h
PR fusionados (30 d)
107

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de sillsdev/interlinearizer-extension

Todos los issues de sillsdev/interlinearizer-extension

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.