Stop reading whole saved projects into the WebView

Cerrado
  • ¿Algo no está bien?
#575 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
48/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
typescript
Área
backend-api-design

Línea de trabajo

Start by reading the InterlinearizerLoader path for fetchSummary, then trace openProject and readOpenableProject in ProjectModals, along with the import view's importLoad and the discard handler. Map the host commands and tests for New, Open, report Open, and Discard; check the flag-on paths against the done criteria. Done means those paths avoid whole-project reads across PAPI and the tests cover all four cases.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Part of Phase 4 (#427). Needs 4a (#453). Blocks 4c (#455).

Background

  • A saved or imported project is stored as one blob (project:{id}).
  • interlinearizer.getProject returns all of it as one JSON string.
  • Past 100 MiB, that reply is over core's WebSocket message cap (MAX_WEBSOCKET_PAYLOAD_BYTES). Main closes the extension host's socket, and every extension reloads.

A PT9 import hits this. A 59-book project is stored at 141.6 MB. The import succeeds, and then Open on the import report crashes the extension host.

Who reads the whole project

Caller What it needs Flag on
fetchSummary in InterlinearizerLoader (the report's Open, sync on open) Summary only Same
The import view's load effect (importLoad) Flag off: seeds the read-only store Unused, except to gate the toolbar's switches (isImportLoading)
openProject in ProjectModals, via readOpenableProject The whole project, to seed the draft Sent back to the host through whole-draft saveDraft (startOver)
handleDiscardChangesConfirm, via readOpenableProject Saved content for the discard Unused: discardBook/discardAll ignore saved, and the host reads it itself (savedContentOf)

Scope

  • Add a summary command, and have fetchSummary use it.
  • Host New and Open:
    • Add a command that starts the session's draft over: from a stored project by id (Open), or empty (New).
    • It clears the session's history (#453's "New and Open").
    • startOver stops sending the draft through saveDraft, which 4c deletes.
  • With the flag on, skip the import view's fetch and the discard's read.
  • Once only the flag-off path uses getProject and readOpenableProject, 4c deletes them.

Not in scope

  • getFullAnalysis still sends the whole analysis at session open and after each change. Until 5d (#459) removes it, an import this size can't open on the host path.
  • The project:{id} blob itself. Reads inside the host don't cross the bus.

Done when

  • With the flag on, no WebView code calls getProject.
  • With the flag on, Open sends a project id and no whole project or draft crosses PAPI.
  • Tests cover New, Open, the report's Open, and Discard on the flag-on path.

Relation to #573

#573 has host New and Open discard unreadable books "in whatever path 4a gives New and Open." This issue builds that path. #573 can land as part of it or after it.

Lenguaje dominante
TypeScript
Estrellas
2
Forks
0
Merge medio
1 d 8 h
PR fusionados (30 d)
85

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de sillsdev/interlinearizer-extension

Todos los issues de sillsdev/interlinearizer-extension

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.