Do not raise error for search archive results
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 2/5
- Tiempo estimado
- 1-3 horas
- Aptitud para principiantes
- 45/100
Línea de trabajo
Start in lib/serpapi/client.rb, especially the get handling around lines 154 and 236. Trace how archive search responses with HTTP 200 and a top-level "error" key are processed, then verify that failed searches can be retrieved without raising an error condition.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
If the HTTP response code is 200, we should not raise an error condition. In practice, trying to investigate a set of failed searches is impossible with the client as it currently works. Consider the following:
Processing IDs from failed-searches.txt...
--------------------------------------------------------------------------------
Search ID | Created At | Processed At | Time Taken
--------------------------------------------------------------------------------
6935c0b9a0cb1015d74ef919: Error - HTTP request failed with status: 200 OK error: Google hasn't returned any results for this query. from url: https://serpapi.com/searches/6935c0b9a0cb1015d74ef919.json
6935c10c6372f3288d198835: Error - HTTP request failed with status: 200 OK error: Google hasn't returned any results for this query. from url: https://serpapi.com/searches/6935c10c6372f3288d198835.json
6935c140d1a72b12298a4c3a: Error - HTTP request failed with status: 200 OK error: Google hasn't returned any results for this query. from url: https://serpapi.com/searches/6935c140d1a72b12298a4c3a.json
6935c1847dcfbe884d95f202: Error - HTTP request failed with status: 200 OK error: Google hasn't returned any results for this query. from url: https://serpapi.com/searches/6935c1847dcfbe884d95f202.json
6935c23c0fa72e068915493a: Error - HTTP request failed with status: 200 OK error: Google hasn't returned any results for this query. from url: https://serpapi.com/searches/6935c23c0fa72e068915493a.json
6935c26f80c963a0739496b7: Error - HTTP request failed with status: 200 OK error: Google hasn't returned any results for this query. from url: https://serpapi.com/searches/6935c26f80c963a0739496b7.json
6935c2a2d99612e9a0b828b2: Error - HTTP request failed with status: 200 OK error: Google hasn't returned any results for this query. from url: https://serpapi.com/searches/6935c2a2d99612e9a0b828b2.json
The search exists, the response was successful, but because of the search api using the same get machinery:
It uses the same handling of the presence of a top level "error" key:
Instead, we should allow retrieval of failed searches from the archive without raising an error.
- Lenguaje dominante
- Ruby
- Estrellas
- 35
- Forks
- 20
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
simp/pupmod-simp-simp#395 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 80/100
simp/pupmod-simp-rsyslog#219 ·
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 90/100
simp/pupmod-simp-pupmod#256 ·
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 90/100
simp/pupmod-simp-sudo#150 ·
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 90/100