feat: scope locals to their block in the type environment

Abierto
#258 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
52/100
Tipo de issue
Nueva funcionalidad
Claridad
Bien especificado
Estado de actividad
Activo
Área
tooling

Línea de trabajo

Start with LookupAt in internal/indexer/goextract/typeenv.go:89 and the test TestShadowedAliasResolvesByPosition in goextract/typeenv_test.go:92. Pick one of the name-only extractors, such as internal/indexer/mainstream/rustextract/typeenv.go:142, and add a shadow test where an inner-block local is followed by a call to the outer name. Done when that test passes and the outer name resolves after the block closes.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area:indexer enhancement priority:low
What exists today?

Each extractor's type environment finds a receiver's type by name. Four extractors also check the position of the call.

  • Go: internal/indexer/goextract/gotypeenv.go:146 calls LookupAt.
  • TypeScript: internal/indexer/tsextract/typeenv.go:139 calls LookupAt.
  • Java: internal/indexer/javaextract/typeenv.go:132 calls LookupAt.
  • C#: internal/indexer/csharpextract/typeenv.go:161 calls LookupAt.

LookupAt is defined at internal/indexer/goextract/typeenv.go:89. It returns the latest declaration whose scope holds the position.

Seven other lookups use the name-only Lookup, which ignores the position:

  • Python: internal/indexer/pyextract/typeenv.go:164
  • Ruby: internal/indexer/mainstream/rubyextract/typeenv.go:96
  • PHP: internal/indexer/mainstream/phpextract/typeenv.go:163
  • Kotlin: internal/indexer/mainstream/kotlinextract/typeenv.go:164
  • Swift: internal/indexer/mainstream/swiftextract/typeenv.go:140
  • Rust: internal/indexer/mainstream/rustextract/typeenv.go:142
  • C and C++: internal/indexer/mainstream/cextract/typeenv.go:175

A whole-body lookup is wrong only where the language ends a local at a block. Kotlin, Swift, Rust, C and C++ do. Ruby ends a local at a do or brace block, but not at if. Python and PHP have no block scope, so a local hides an outer name for the whole function. internal/indexer/goextract/scope.go:68 records the PHP rule.

No fixture covers a block-scoped shadow in these seven extractors yet.

How does it behave now?

Reading internal/indexer/mainstream/rustextract/typeenv.go:142, the lookup ignores the block. A local declared in an inner block still answers a call after that block closes. This is from reading the code. A run of the Rust extractor on a shadow fixture has not been done.

How should it behave?

Each extractor scopes a local by its language's rule:

  • Kotlin, Swift, Rust, C and C++: from the declaration to the end of the enclosing block.
  • Ruby: from the declaration to the end of the enclosing do or brace block.
  • Python and PHP: whole-function scope, which the language defines.

A call resolves to the declaration whose scope holds its position, as LookupAt does for Go. A call after an inner block resolves to the outer name again.

Add one shadowing test per extractor, modelled on TestShadowedAliasResolvesByPosition at internal/indexer/goextract/typeenv_test.go:92. Each test declares an inner-block local, then calls the outer name after the block. The test asserts the outer resolution. The Python and PHP tests assert whole-function scope, so the rule stays fixed.

The spec in openspec/specs/graph-index/spec.md already requires this. Its requirement is "A same-file reference resolves by lexical scope." The design of the per-body type environment is in openspec/changes/archive/2026-11-02-index-invariants/design.md, decision D17.

Would this change existing behavior?

Yes. Some calls that resolve today to an inner-block local will resolve to the outer name, or stay unresolved. The output shape does not change.

What kind of improvement?

Correctness in an edge case

Before submitting
  • I searched existing issues and this is not a duplicate
  • I checked that the current behavior is not a deliberate decision in openspec/specs/
Lenguaje dominante
Go
Estrellas
0
Forks
0
Merge medio
7 h 42 min
PR fusionados (30 d)
111

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de seanb4t/codegraph-go

Todos los issues de seanb4t/codegraph-go

Issues similares

Más issues de Go

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.