feat: scope locals to their block in the type environment
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Aptitud para principiantes
- 52/100
Línea de trabajo
Start with LookupAt in internal/indexer/goextract/typeenv.go:89 and the test TestShadowedAliasResolvesByPosition in goextract/typeenv_test.go:92. Pick one of the name-only extractors, such as internal/indexer/mainstream/rustextract/typeenv.go:142, and add a shadow test where an inner-block local is followed by a call to the outer name. Done when that test passes and the outer name resolves after the block closes.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
What exists today?
Each extractor's type environment finds a receiver's type by name. Four extractors also check the position of the call.
- Go:
internal/indexer/goextract/gotypeenv.go:146callsLookupAt. - TypeScript:
internal/indexer/tsextract/typeenv.go:139callsLookupAt. - Java:
internal/indexer/javaextract/typeenv.go:132callsLookupAt. - C#:
internal/indexer/csharpextract/typeenv.go:161callsLookupAt.
LookupAt is defined at internal/indexer/goextract/typeenv.go:89. It returns the latest declaration whose scope holds the position.
Seven other lookups use the name-only Lookup, which ignores the position:
- Python:
internal/indexer/pyextract/typeenv.go:164 - Ruby:
internal/indexer/mainstream/rubyextract/typeenv.go:96 - PHP:
internal/indexer/mainstream/phpextract/typeenv.go:163 - Kotlin:
internal/indexer/mainstream/kotlinextract/typeenv.go:164 - Swift:
internal/indexer/mainstream/swiftextract/typeenv.go:140 - Rust:
internal/indexer/mainstream/rustextract/typeenv.go:142 - C and C++:
internal/indexer/mainstream/cextract/typeenv.go:175
A whole-body lookup is wrong only where the language ends a local at a block. Kotlin, Swift, Rust, C and C++ do. Ruby ends a local at a do or brace block, but not at if. Python and PHP have no block scope, so a local hides an outer name for the whole function. internal/indexer/goextract/scope.go:68 records the PHP rule.
No fixture covers a block-scoped shadow in these seven extractors yet.
How does it behave now?
Reading internal/indexer/mainstream/rustextract/typeenv.go:142, the lookup ignores the block. A local declared in an inner block still answers a call after that block closes. This is from reading the code. A run of the Rust extractor on a shadow fixture has not been done.
How should it behave?
Each extractor scopes a local by its language's rule:
- Kotlin, Swift, Rust, C and C++: from the declaration to the end of the enclosing block.
- Ruby: from the declaration to the end of the enclosing
door brace block. - Python and PHP: whole-function scope, which the language defines.
A call resolves to the declaration whose scope holds its position, as LookupAt does for Go. A call after an inner block resolves to the outer name again.
Add one shadowing test per extractor, modelled on TestShadowedAliasResolvesByPosition at internal/indexer/goextract/typeenv_test.go:92. Each test declares an inner-block local, then calls the outer name after the block. The test asserts the outer resolution. The Python and PHP tests assert whole-function scope, so the rule stays fixed.
The spec in openspec/specs/graph-index/spec.md already requires this. Its requirement is "A same-file reference resolves by lexical scope." The design of the per-body type environment is in openspec/changes/archive/2026-11-02-index-invariants/design.md, decision D17.
Would this change existing behavior?
Yes. Some calls that resolve today to an inner-block local will resolve to the outer name, or stay unresolved. The output shape does not change.
What kind of improvement?
Correctness in an edge case
Before submitting
- I searched existing issues and this is not a duplicate
- I checked that the current behavior is not a deliberate decision in
openspec/specs/
- Lenguaje dominante
- Go
- Estrellas
- 0
- Forks
- 0
- Merge medio
- 7 h 42 min
- PR fusionados (30 d)
- 111
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de seanb4t/codegraph-go
-
chore needs-triage
Dificultad 1/5 Menos de una hora Aptitud para principiantes 88/100
seanb4t/codegraph-go#380 ·
Los mantenedores suelen responder en 1 día
-
chore needs-triage
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
seanb4t/codegraph-go#379 ·
Los mantenedores suelen responder en 1 día
-
area:query chore needs-triage spec-needed
Dificultad 2/5 1-3 horas Aptitud para principiantes 74/100
seanb4t/codegraph-go#377 ·
Los mantenedores suelen responder en 1 día
-
chore needs-triage
Dificultad 1/5 1-3 horas Aptitud para principiantes 84/100
seanb4t/codegraph-go#362 ·
Los mantenedores suelen responder en 1 día
-
area:query bug needs-triage
Dificultad 2/5 1-3 horas Aptitud para principiantes 80/100
seanb4t/codegraph-go#355 ·
Los mantenedores suelen responder en 1 día
Todos los issues de seanb4t/codegraph-go
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 77/100
Los mantenedores suelen responder en 1 día
-
automated documentation maintenance
Dificultad 1/5 1-3 horas Aptitud para principiantes 75/100
github/gh-aw-mcpg#16717 ·
Los mantenedores suelen responder en 1 día
-
Docs: Recording rules pages don't say what happens to a recorded metric when its rule is deletedAbiertointernal
Dificultad 1/5 1-3 horas Aptitud para principiantes 84/100
Los mantenedores suelen responder en 1 día
-
enhancement
Dificultad 2/5 1-3 horas Aptitud para principiantes 74/100
jesseduffield/lazygit#6229 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
prometheus/prometheus#20482 ·
Los mantenedores suelen responder en 2 días