`stable 3006` installs 3008.3 when `config-manager` fails (Fedora dnf5, Rocky Linux container images)

Abierto
  • ¿Algo no está bien?
#2,149 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
53/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
bash, fedora, linux, shell
Área
backend, devops

Línea de trabajo

Read bootstrap-salt.sh functions __install_saltstack_fedora_onedir_repository (around lines 4181–4228) and __install_saltstack_rhel_onedir_repository (around 4520–4567), then trace how each selects the repository before installing Salt. Reproduce with the Rocky Linux 9 or Fedora 44 container commands in the issue. Done means stable 3006 and stable 3007 install their matching versions even when config-manager is unavailable or rejects the options.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Description of Issue/Question

For a major-only version (stable 3006, stable 3007) on Fedora and the RHEL family, bootstrap-salt.sh downloads the official salt.repo and relies on config-manager to leave only the matching section enabled:

yum config-manager --set-disable salt-repo-*
yum config-manager --set-enabled salt-repo-3006-lts

(dnf config-manager in the Fedora function.) The exit status isn't checked and the package install is unversioned, so when config-manager fails the file stays as shipped. salt.repo from salt-install-guide v2.4.2 has both [salt-repo-3006-lts] and [salt-repo-3008-lts] set to enabled=1, so 3008.3 is installed.

I've seen config-manager fail in two cases:

  • Fedora 43 and 44: dnf5's config-manager doesn't take the dnf4 options, even with dnf5-plugins installed: Unknown argument "--set-disable" for command "config-manager". stable 3007 on Fedora 44 also gets 3008.3.
  • docker.io/rockylinux/rockylinux:9 and :10: the images don't have python3-dnf-plugins-core, so it's No such command: config-manager. The script still ends with "Salt installed!" and exits 0. yum-utils gets installed (line 4831) only after the repo setup (line 4821). The almalinux:9 and :10 images ship the plugin and get 3006.28.

CI doesn't catch it: there's no Fedora job, and the salt-ci-containers rockylinux-9 image installs dnf-command(config-manager).

Code, line numbers from v2026.10.08 (develop is identical):

  • __install_saltstack_fedora_onedir_repository (4181): 4199-4209 and 4227-4228
  • __install_saltstack_rhel_onedir_repository (4520): 4538-4548 and 4566-4567

The 3006 and 3008+ branches came in with #2120 for #2119.

Possible fixes: install dnf-command(config-manager) before the repo function and fail if config-manager fails. On dnf5 the equivalent is dnf config-manager setopt 'salt-repo-*.enabled=0' followed by a separate dnf config-manager setopt salt-repo-3006-lts.enabled=1 (dnf5 rejects both in one call). Or set enabled= in the downloaded salt.repo directly, which doesn't need the plugin at all.

Setup

No config. Stock container images, x86_64, run with podman.

Steps to Reproduce Issue

In docker.io/rockylinux/rockylinux:9, with bootstrap-salt.sh v2026.10.08 copied in:

sh bootstrap-salt.sh -X -D stable 3006
rpm -q salt-minion                  # salt-minion-3008.3-0.x86_64
dnf repolist --all | grep salt      # salt-repo-3006-lts and salt-repo-3008-lts enabled

The same on registry.fedoraproject.org/fedora:44. There the script exits 1 at install_fedora_check_services() because the container has no systemd, but salt is already installed by then.

Versions and Systems

bootstrap-salt.sh -- Version 2026.10.08 (develop ddddb88 is the same file)
salt.repo from salt-install-guide v2.4.2
Rocky Linux 9.8 (dnf 4.14.0), Rocky Linux 10.2 (dnf 4.20.0), Fedora 43 (dnf5 5.2.18), Fedora 44 (dnf5 5.4.6)

Lenguaje dominante
Shell
Estrellas
953
Forks
541
Merge medio
2 d 19 h
PR fusionados (30 d)
3

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de saltstack/salt-bootstrap

Todos los issues de saltstack/salt-bootstrap

Issues similares

Más issues de Shell/Bash

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.