`repr(transparent)` ignores fields that do not have "trivial ABI"

Abierto
#166,183 1 comentario 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
38/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
rust
Área
compilers

Línea de trabajo

Read the linked PRs #157973 and #155984 to understand the trivial ABI change and the stalled implementation. Then trace how repr(transparent) determines which fields it ignores and inspect the related compiler tests. Done means transparent representation ignores only fields with trivial ABI, with regression coverage for the two zero-sized array fields shown in the issue.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

A-ABI C-bug T-lang T-opsem

In https://github.com/rust-lang/rust/pull/157973 we introduced the concept of "trivial ABI", and declared that types like [u8; 0] or repr(C) 1-ZST do not have trivial ABI. However, repr(transparent) still ignores such types, so we accept e.g.

#[repr(transparent)]
struct S {
  a: [u8; 0],
  b: [i8; 0],
}

Since it's not clear which field is being wrapped by S, we basically have to make S ABI-compatible with all its fields, but the two fields are not ABI-compatible so that does not work out. We should therefore transition repr(transparent) to only ignore fields that have "trivial ABI".

@Jules-Bertholet started working on that in https://github.com/rust-lang/rust/pull/155984. However, the work has stalled, so I figured it'd be worth opening an issue to track this. @Jules-Bertholet do you still plan to get back to that PR, or would you be fine with someone else picking up the work?

Lenguaje dominante
Rust
Estrellas
122k
Forks
16.7k
Merge medio
2 d 16 h
PR fusionados (30 d)
515

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de rust-lang/rust

Todos los issues de rust-lang/rust

Issues similares

Más issues de Rust

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.