Next-generation trait solver has different compilation failure error output
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Aptitud para principiantes
- 22/100
Línea de trabajo
The payload compares two rustc diagnostic outputs for the same Send/Sync failure in tests/compile_fail/diff_send.rs (git2-rs), involving src/diff.rs and src/repo.rs. The compiler code that builds these errors is not named, so the first step is to reproduce the difference by running the same file on stable and with the new solver. Done means the new-solver stderr reports the same notes as stable, which is a compiler-internals change and not a first-timer task.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
when using trybuild to check the stderr output for compilation failures, the new solver seems to report less - https://github.com/rust-lang/git2-rs/actions/runs/43620785786/job/132525764327 / rust-lang/git2-rs#1342
On stable
error[E0277]: `*mut libgit2_sys::git_diff` cannot be sent between threads safely
--> tests/compile_fail/diff_send.rs:27:17
|
27 | s.spawn(move || theirs.stats().unwrap().insertions());
| ----- -------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
| | |
| | `*mut libgit2_sys::git_diff` cannot be sent between threads safely
| | within this `{closure@$DIR/tests/compile_fail/diff_send.rs:27:17: 27:24}`
| required by a bound introduced by this call
|
= help: within `{closure@$DIR/tests/compile_fail/diff_send.rs:27:17: 27:24}`, the trait `Send` is not implemented for `*mut libgit2_sys::git_diff`
note: required because it appears within the type `Diff<'_>`
--> src/diff.rs
|
| pub struct Diff<'repo> {
| ^^^^
note: required because `theirs` is used within this closure
--> tests/compile_fail/diff_send.rs:27:25
|
27 | s.spawn(move || theirs.stats().unwrap().insertions());
| ^^^^^^
note: required by a bound in `Scope::<'scope, 'env>::spawn`
--> $RUST/std/src/thread/scoped.rs
error[E0277]: `*mut libgit2_sys::git_repository` cannot be shared between threads safely
--> tests/compile_fail/diff_send.rs:27:17
|
27 | s.spawn(move || theirs.stats().unwrap().insertions());
| ----- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ `*mut libgit2_sys::git_repository` cannot be shared between threads safely
| |
| required by a bound introduced by this call
|
= help: within `git2::Repository`, the trait `Sync` is not implemented for `*mut libgit2_sys::git_repository`
note: required because it appears within the type `git2::Repository`
--> src/repo.rs
|
| pub struct Repository {
| ^^^^^^^^^^
= note: required for `&git2::Repository` to implement `Send`
note: required because it appears within the type `PhantomData<&git2::Repository>`
--> $RUST/core/src/marker.rs
note: required because it appears within the type `Diff<'_>`
--> src/diff.rs
|
| pub struct Diff<'repo> {
| ^^^^
note: required because `theirs` is used within this closure
--> tests/compile_fail/diff_send.rs:27:25
|
27 | s.spawn(move || theirs.stats().unwrap().insertions());
| ^^^^^^
note: required by a bound in `Scope::<'scope, 'env>::spawn`
--> $RUST/std/src/thread/scoped.rs
On nightly/with new solver
error[E0277]: `*mut libgit2_sys::git_diff` cannot be sent between threads safely
--> tests/compile_fail/diff_send.rs:27:17
|
27 | s.spawn(move || theirs.stats().unwrap().insertions());
| ----- -------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
| | |
| | `*mut libgit2_sys::git_diff` cannot be sent between threads safely
| | within this `{closure@$DIR/tests/compile_fail/diff_send.rs:27:17: 27:24}`
| required by a bound introduced by this call
|
= help: within `{closure@$DIR/tests/compile_fail/diff_send.rs:27:17: 27:24}`, the trait `Send` is not implemented for `*mut libgit2_sys::git_diff`
note: required because it appears within the type `Diff<'_>`
--> src/diff.rs
|
| pub struct Diff<'repo> {
| ^^^^
note: required because `theirs` is used within this closure
--> tests/compile_fail/diff_send.rs:27:25
|
27 | s.spawn(move || theirs.stats().unwrap().insertions());
| ^^^^^^
note: required by a bound in `Scope::<'scope, 'env>::spawn`
--> $RUST/std/src/thread/scoped.rs
- Lenguaje dominante
- Rust
- Estrellas
- 122k
- Forks
- 16.7k
- Merge medio
- 2 d 16 h
- PR fusionados (30 d)
- 515
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de rust-lang/rust
-
Remove unnecessary parentheses when suggesting to remove '&' from a patternPosiblemente ocupada @BartSimpson001 la tomó hace 1 día. AbiertoA-diagnostics D-invalid-suggestion T-compiler
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
Los mantenedores suelen responder en 1 día
-
Windows `File::set_permissions` silently does nothing when clearing `readonly` leaves `FileAttributes == 0`Posiblemente ocupada @ChrisDenton la tomó hace 11 días. AbiertoA-filesystem C-bug O-windows T-libs
Dificultad 2/5 1-3 horas Aptitud para principiantes 62/100
Los mantenedores suelen responder en 1 día
-
A-run-make relnotes relnotes-needs-review relnotes-tracking-issue T-lang T-libs
Dificultad 1/5 Menos de una hora Aptitud para principiantes 72/100
Los mantenedores suelen responder en 1 día
-
A-LLVM O-Arm O-UEFI O-x86_64 relnotes relnotes-needs-review relnotes-tracking-issue T-compiler
Dificultad 1/5 Menos de una hora Aptitud para principiantes 72/100
rust-lang/rust#165504 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
relnotes relnotes-tracking-issue T-libs
Dificultad 1/5 Menos de una hora Aptitud para principiantes 72/100
Los mantenedores suelen responder en 1 día
Todos los issues de rust-lang/rust
Issues similares
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 88/100
bytecodealliance/wrpc#1785 ·
Los mantenedores suelen responder en 1 día
-
2 advisory ignore entries no longer match anything (`quick-xml` already patched in `Cargo.lock`)Abierto
Dificultad 1/5 Menos de una hora Aptitud para principiantes 85/100
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
longbridge/nsh#2758 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 84/100
antithesishq/bombadil#473 ·
Los mantenedores suelen responder en 2 días
-
bench/api.sh exec test fails with curl exit 52, and --ignore-failure still records the timingsAbiertobug
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
libracoder/kiri#669 ·
Los mantenedores suelen responder en 1 día