Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

Object property defined with Object.defineProperty gets immediately evaluated

Abierto
  • ¿Algo no está bien?
#197 5 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
35/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Estancado
Stack tecnológico
javascript, ruby
Área
backend, devtools

Línea de trabajo

Start by reading the MiniRacer context loading path and how it handles enumerable properties with getters; the issue does not name source files or tests. Reproduce the behavior with the provided Object.defineProperty example in a MiniRacer context, then compare it with browser behavior. Done means explaining whether the getter evaluation is expected or fixing the discrepancy, with a regression test.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Hello,

I hope this is the right place to ask...
I have a lot of components defined in different files and in my ruby code I'm loading them using the load function:

def initialize_js(config, locale = nil)
    ctx = MiniRacer::Context.new

    ...

    Dir.entries(path.join('auto', 'utils')).sort.each do |ent|
      next if ent.start_with? '.'

      if ent.end_with? '.js'
        ctx.load(path.join('auto', 'utils', ent))
      else
        next unless File.directory?(path.join('auto', 'utils', ent))

        Dir.entries(path.join('auto', 'utils', ent)).sort.each do |ent2|
          next if ent2.start_with? '.'

          ctx.load(path.join('auto', 'utils', ent, ent2))
        end
      end
    end

    ...

    ctx
  end

I moved outside of the component's init function the definition of a property:

Before:

utils.components.accessory_power_adapter = {
  init: function(config, components) {
    if(this.initialized) return;

    Object.defineProperty(components, 'accessory_power_adapter', {
      enumerable: true,
      get: function() {
        return this.component;
      }.bind(utils.components.accessory_power_adapter)
    });

    // Initialize component
    this._init_component(config, components);

    this.initialized = true;
  },

...

};

After:

utils.components.accessory_power_adapter = {
  init: function(config, components) {
    if(this.initialized) return;

    // Initialize component
    this._init_component(config, components);

    this.initialized = true;
  },

...

};

Object.defineProperty(components, 'accessory_power_adapter', {
  enumerable: true,
  get: function() {
    if(!this.initialized) {
      throw 'call to components.accessory_power_adapter but the component is not initialized yet!';
    }

    return this.component;
  }.bind(utils.components.accessory_power_adapter)
});

And now I'm getting the exception

call to components.accessory_power_adapter but the component is not initialized yet!'

when I simply load the file in the context.
It looks to me that somehow after defining the property, the engine tries to access it and since the component is not initialized yet, I get the exception.
I don't know if this is a bug or it's the expected behavior, I'm running the same code in the browser and it's fine.
If I make the property not enumerable it doesn't happen, but I need the property to be enumerable, so the only workaround is to change the code to skip that check if I'm running the code server side:

Object.defineProperty(components, 'accessory_power_adapter', {
  enumerable: true,
  get: function() {
    if(!this.initialized && !ruby) {
      throw 'call to components.accessory_power_adapter but the component is not initialized yet!';
    }

    return this.component;
  }.bind(utils.components.accessory_power_adapter)
});

But I wanted to know why it is happening, if I've found a bug or I'm doing something wrong.
Thank you for your support!

mini_racer 0.4.0
libv8-node (15.14.0.0)
Lenguaje dominante
JavaScript
Estrellas
628
Forks
100
Merge medio
1 d 20 h
PR fusionados (30 d)
2

Preparar el entorno

  • Incluye un Dockerfile o un archivo de Docker Compose
  • Sin plantilla de pull request
  • Sin guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de rubyjs/mini_racer

Todos los issues de rubyjs/mini_racer

Issues similares

Más issues de JavaScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.