Speed up CI: split tests across machines + fix hot spec files (cruft removal won't help)

Abierto
#2,933 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
30/100
Tipo de issue
Refactorización
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
github-actions, ruby
Área
ci-cd, testing

Línea de trabajo

Start with the timing table: the hot spec files are spec/requests/dedupable_spec.rb, spec/services/tag_alias_seeder_spec.rb and spec/requests/events_spec.rb, and the test step runs under parallel_rspec. Splitting jobs across matrix runs means changing the CI workflow, which the payload does not name, so confirm the maintainers want that before starting. Done means a measured drop in wall-clock CI time, with the 17 pending examples handled separately.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

blocked

🤖 From Claude:

CI takes 11–13 min. Deleting old/redundant specs won't fix that: removing every cruft candidate saves only about 25s. The time goes to the test step itself and a handful of slow spec files.

Measured from the per-example timing files of one green CI run (12,769 examples).

Where the time goes (one run, 11 min total)

Step Time
Setup (containers, Ruby, npm, Vite build, DBs) ~1:40
parallel_rspec, 4 processes 9:21
  • Total example time is 34.6 min, split 4 ways. Processes finished between 7:50 and 9:14.
  • By directory: requests 16.2 min (47%), services 8.0, system 3.8, models 3.4, everything else ~3.
  • Factories are cheap (2–40ms per create), so they aren't the cause.

Cruft: low value

Candidate Examples Total time Wall-clock saved
Auth-gate request specs (guest / regular user / denied) 463 1.0 min ~15s
View specs 563 0.5 min ~8s
Scaffold-style request specs 101 0.1 min ~2s
Pending/skipped examples 17 0 0
  • Delete or fix the 17 pending examples for hygiene. It won't speed anything up.
  • Keep the auth-gate specs. They're cheap and check the real routing and redirects.

Real levers

  1. Split tests across 2–3 GitHub Actions matrix jobs (biggest win)

    • 2 machines × 4 processes → tests ~4.5 min, CI ~6.5 min. 3 machines → CI ~5 min.
    • Repo is public, so standard runners are free.
    • parallel_rspec --only-group lets each job take a share.
  2. Speed up the hot files. The top 12 files are ~35% of all example time:

    File Time Examples Per example
    spec/requests/dedupable_spec.rb 124s 113 ~1.1s
    spec/requests/events_spec.rb 81s 413
    spec/services/event_registration_services/public_registration_spec.rb 77s 110 0.7s
    spec/requests/people_dedupe_professional_licenses_spec.rb 68s 31 2.2s
    spec/services/event_dashboard_spec.rb 57s 143
    spec/services/tag_alias_seeder_spec.rb 46s 23 2s (runs the whole seeder in every example)
    • Running heavy setup once per file instead of once per example could roughly halve these, saving ~1.5 min wall clock.
  3. Group by runtime instead of file size

    • Record a runtime log (ParallelTests::RSpec::RuntimeLogger) and use --group-by runtime.
    • Evens out the 7:50 vs 9:14 spread, saving ~30–40s.
  4. Two slow system specs (11–13s each), low priority

    • community_news_index_spec.rb:170 and notification_incoming_responded_spec.rb:8.
    • Probably slow only because they run first in their process and wait for Chrome to start.
Lenguaje dominante
Ruby
Estrellas
15
Forks
28
Merge medio
14 h 29 min
PR fusionados (30 d)
292

Preparar el entorno

Abrir en Codespaces

Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de rubyforgood/awbw

Todos los issues de rubyforgood/awbw

Issues similares

Más issues de Ruby

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.