Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

Ahoy lifecycle tracking silently drops changes made with no Current actor

Abierto
  • ¿Algo no está bien?
#2,351 1 comentario 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
52/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
ruby
Área
backend

Línea de trabajo

Comienza en ApplicationController, Events::CalloutsController y Analytics::LifecycleBuffer para rastrear cómo se establece Current.source y cuándo se vacían los eventos del ciclo de vida. Reproduce el flujo de scholarship agreement con la sesión cerrada y una escritura de modelo fuera de una solicitud, y añade specs enfocadas que muestren que la acción pública se atribuye y que el comportamiento fuera de una solicitud se gestiona explícitamente.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

bug

🤖 From Claude:

AhoyTrackable (included in ApplicationRecord) tracks create/update/destroy for every model, but track_lifecycle_event opens with:

return unless Current.user || Current.source

Current.user is only set for a signed-in request (ApplicationController#set_current_user), and Current.source is set in exactly two places (public_forms_controller, events/public_registrations_controller). Everything else that writes without a signed-in user leaves no trace at all — no event, no error, no log line.

Verified

Calling scholarship.accept_agreement!(by: "recipient") with no actor set:

Actor Buffered events
none []
Current.user set update.scholarship, create.scholarship_agreement_response
Current.source set update.scholarship, create.scholarship_agreement_response

Where this bites today

  • Scholarship accept/decline on the public callout. Events::CalloutsController does skip_before_action :authenticate_user! and never sets Current.source, so a logged-out recipient accepting or declining their agreement produces no Ahoy event. The bespoke scholarship_agreement_responses log is currently the only record of it.
  • Anything outside a request — jobs, rake tasks, console, webhooks (Stripe). These are dropped twice over: the actor guard, and Analytics::LifecycleBuffer only flushing in ApplicationController's after_action, so a buffered event outside a request is never written.

Recommendation

Close the request-shaped hole narrowly rather than removing the guard.

  1. Default a source for every actorless request — one line in ApplicationController: set Current.source when there's no signed-in user, so any public flow (present or future) is covered without each controller having to remember. Named per controller where it matters, generic otherwise.
  2. Opt non-request contexts in explicitly — jobs, webhooks, and rake tasks set their own Current.source ("stripe_webhook", "job:x"), and LifecycleBuffer needs a flush path that doesn't depend on a controller.
  3. Don't just delete the guard. Seeds, imports, and the test suite would start emitting events in volume, which is presumably why it's there.

Acceptance

  • A logged-out recipient accepting a scholarship agreement produces an Ahoy event attributed to a named source.
  • A model write inside a job produces an event (or is a documented, deliberate exclusion).
  • Specs cover both, so the guard can't silently re-open the hole.
Lenguaje dominante
Ruby
Estrellas
15
Forks
28
Merge medio
1 d 12 min
PR fusionados (30 d)
262

Preparar el entorno

Abrir en Codespaces

Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de rubyforgood/awbw

Todos los issues de rubyforgood/awbw

Issues similares

Más issues de Ruby

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.