Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

Confirm: comped CE fees count as org subsidy in the revenue report

Abierto
  • ¿Algo no está bien?
#2,084 1 comentario 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
35/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Tranquilo
Stack tecnológico
ruby
Área
backend

Línea de trabajo

Revisa app/services/event_revenue_figures.rb y el ejemplo de tarifas CE con descuento en spec/services/event_revenue_report_spec.rb; después, compara el tratamiento actual de los descuentos de inscripción con el flujo de asignación de CE en app/views/continuing_education_registrations/_payment_history.html.erb. Confirma el tratamiento contable de los descuentos CE completos y parciales y si la página de ingresos necesita líneas de descuento separadas; se considera terminado cuando la política esté acordada y el comportamiento del informe y las pruebas coincidan con ella.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

event mgmt stakeholder-question
The problem

A CE fee can only ever end up in one of three places: paid, comped (a discount allocation), or owed. #2072 made "paid" and "owed" real figures on the events revenue report — but nothing claimed the comped slice, so a fully-discounted CE fee was neither collected nor outstanding and disappeared from the report entirely.

Example — a $60 CE fee comped in full:

Before #2072 #2072 as first written #2072 as merged
Fees collected $0 $0 $0
Outstanding $60 (never collectable) $0 $0
Org subsidy $0 $0 $60
Net $0 $0 −$60

The middle column is the hole: $60 of value the org gave away, invisible on every figure.

What we did

Counted CE discounts as org subsidy, matching how a discounted registration fee is already treated. Net and total expected drop by the comped amount. Implemented in EventRevenueFigures (app/services/event_revenue_figures.rb) — it's the one place the batched report figures deliberately diverge from EventDashboard.

What needs confirming
  • Is "the org gave away $60" the right read of a comped CE fee for annual-report purposes? (The alternative is treating CE comps as never-was-revenue, i.e. leaving them out of every bucket — which is what was happening by accident.)
  • Should the same reasoning extend to a partially comped CE fee ($60 fee, $20 discount, $40 paid → $20 subsidy)? That's what the code does today; flagging it because it wasn't discussed separately.
  • Does the revenue page need to show CE discounts broken out from registration discounts, or is one combined "Discounts" line enough?
Context
  • Introduced by #2072
  • app/services/event_revenue_figures.rb — discount_cents sums Discount allocations across both EventRegistration and ContinuingEducationRegistration
  • spec/services/event_revenue_report_spec.rb — "discounted CE fees" describes the expected accounting
  • CE comps are reachable in the UI today: the allocations page for a CE registration (app/views/continuing_education_registrations/_payment_history.html.erb) has an "Add discount" action
Lenguaje dominante
Ruby
Estrellas
15
Forks
28
Merge medio
1 d 12 min
PR fusionados (30 d)
262

Preparar el entorno

Abrir en Codespaces

Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de rubyforgood/awbw

Todos los issues de rubyforgood/awbw

Issues similares

Más issues de Ruby

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.