Split gem into Ruby and extension parts
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Aptitud para principiantes
- 25/100
- Tipo de issue
- Nueva funcionalidad
- Claridad
- Necesita aclaración
- Estado de actividad
- Estancado
Línea de trabajo
No se nombran archivos ni pruebas. Empieza por rastrear el empaquetado actual de prism gem y la compilación de la extensión nativa; después, evalúa los artefactos propuestos de prism y prism-ext y la ruta WASM de JRuby; se considera terminado cuando la división y el comportamiento por plataforma estén implementados, y el paquete prism de JRuby excluya las bibliotecas nativas.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
I would like to split the current Prism gem into two pieces: "prism" which contains the Ruby parts of the library, and "prism-ext" which contains the native extension and native library. This makes most sense for JRuby, but it would be simpler if done as a general move.
This is less of an issue and more of an idea that would make our lives easier in the JRuby world.
For JRuby users, the dependency on a native library is usually problematic. A large percentage of JRuby users (perhaps a majority) deploy JRuby into environments where there's no C build tools and frequently no allowances for random native libraries on the filesystem. Some of these deployments are all-in-one bundles that don't even unpack files to the filesystem. In such cases, the native library can't be built or loaded.
The most sensible option for the prism gem for JRuby would be that it ships only what can be run without native libraries; specifically this would mean prism would ship the WASM version of Prism so it can be embedded and bundled in all the ways JRuby users depend upon.
Users could opt-into the faster native Prism build by installing prism-ext or prism-library, which would build the dynamic library and make it available to the prism library. We would only ship prism as part of JRuby releases, since we need our distribution to always work across platforms.
The native-extension implementations would continue to just use the ext or the dynamic library as today.
The artifacts would look something like this:
prismgem includes only the Ruby parts of the library and can be patched and versioned independently of the native code.prism-extwould work like the currentprismgem does, building and installing either the CRuby extension or the dynamic library.- The normal non-platform-specific version of the
prismgem would depend uponprism-ext. - The
javaplatform version of theprismgem (for JRuby) would ship only the Ruby parts and the WASM library. Users can opt into the native version by installingprism-ext.
Alternatively, these changes would only apply to JRuby, and prism-ext would only be for JRuby users. Either way, the main prism gem for JRuby will need to exclude the native library.
I can think of other benefits to separating the extension into its own gem:
- CRuby users would be able to update just the Ruby part of Prism while still using the built-in native extension. This might make some bug fixes easier to distribute.
- If TruffleRuby in the future chooses to run Prism in a different form such as with Chicory or TruffleWasm, it would be a natural progression of this split.
- Doing the split uniformly (rather than just for JRuby) will keep the differences minimal. CRuby users would just get an additional extension dependency.
- Lenguaje dominante
- C
- Estrellas
- 1k
- Forks
- 194
- Merge medio
- 2 d 9 h
- PR fusionados (30 d)
- 15
Preparar el entorno
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de ruby/prism
-
Dificultad 4/5 3-5 días Aptitud para principiantes 58/100
Los mantenedores suelen responder en 1 día
-
Trailing comma in ASTAbiertoenhancement
Dificultad 5/5 Más de una semana Aptitud para principiantes 35/100
ruby/prism#4091 · 1 comentario · 1 reacción ·
Los mantenedores suelen responder en 1 día
-
Revisit commentsAbiertoenhancement
Dificultad 5/5 Más de una semana Aptitud para principiantes 30/100
ruby/prism#4044 · 4 comentarios ·
Los mantenedores suelen responder en 1 día
-
java
Dificultad 5/5 Más de una semana Aptitud para principiantes 25/100
ruby/prism#4040 · 5 comentarios ·
Los mantenedores suelen responder en 1 día
-
Release official Java APIAbiertojava
Dificultad 5/5 Más de una semana Aptitud para principiantes 25/100
ruby/prism#4018 · 10 comentarios ·
Los mantenedores suelen responder en 1 día
Todos los issues de ruby/prism
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
ARM-software/sysarch-acs#556 · 1 comentario ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
Los mantenedores suelen responder en 1 día
-
bug needs triage
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
netdata/netdata#24062 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100