Lookahead's `selects?` returns false for a field that is visible in `#selections` on a Union type

Abierto
  • ¿Algo no está bien?
#4,388 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
42/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Estancado
Stack tecnológico
graphql, rails, ruby
Área
api, backend

Línea de trabajo

Start in Resolvers::SavedRepliesTreeResolver and reproduce the query with the Union type, comparing lookahead.selects?(:attachment) with lookahead.selections. Read the lookahead behavior for union selections and verify that attachment is recognized by selects? while the existing selections remain visible.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Describe the bug

Inside my resolver, whenever I call .selects?(:attachment), it returns false. Although the :attachment field is present whenever I do lookahead.selections.map(&:name) I find that the :attachment field is present

Versions

graphql: 1.13.15
rails: 6.0.3

GraphQL schema

# Types
class SavedReplyFolderType < ::Types::BaseObject
  # fields that are not :attachment
end

class SavedReplyType < ::Types::BaseObject
  # other fields
  field :attachment, ::Types::AttachmentType, null: true
end

class SavedReplyLeafUnion < ::Types::BaseUnion
  possible_types Types::SavedReplyType, Types::SavedReplyFolderType

  def self.resolve_type(object, context)
    if object.is_a?(::SavedReply)
      Types::SavedReplyType
    elsif object.is_a?(::SavedReplyFolder)
      Types::SavedReplyFolderType
    end
  end
end


# Resolvers
# Resolver for [SavedReplyLeafUnion]
module Resolvers
  class SavedRepliesTreeResolver < BaseResolver
    extras [:lookahead]
    def resolve(lookahead:)
       # try accessing lookahead here
    end
  end
end

GraphQL query

query savedRepliesTree {
  app {
    savedRepliesTree {
      __typename
      ... on SavedReply {
				attachment {
          id
        }
      }
      ... on SavedReplyFolder {
        id
      }
    }
  }
}

Steps to reproduce

use byebug inside the resolver
Try doing

(byebug) lookahead.selects?(:attachment)
false

to find that the attachment cannot be found on the lookahead

but whenever you do

(byebug) lookahead.selections.map(&:name)
[:__typename, :attachment, :id]

You'll find that the attachment field exists

Expected behavior

lookahead.selects?(:attachment) should return true

Lenguaje dominante
Ruby
Estrellas
5.4k
Forks
1.4k
Merge medio
1 d 8 h
PR fusionados (30 d)
74

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de rmosolgo/graphql-ruby

Todos los issues de rmosolgo/graphql-ruby

Issues similares

Más issues de Ruby

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.