Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

Cache keys are hashed absolute paths, so the cache can never be reused across checkouts (CI → local, git worktrees)

Abierto
#8,488 1 comentario 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
55/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
php
Área
tooling

Línea de trabajo

Start with ChangedFilesDetector, especially getFilePathCacheKey() and resolvePath(), then trace how cache entries are written and read. Decide how the project root is supplied and how paths outside it behave, using the issue's PHPStan comparison as context. Done means cache entries can be reused across equivalent checkouts without breaking existing cache reads.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Subject Details
Rector version 2.6.6
Installed as composer dependency

ChangedFilesDetector keys every cache entry on the absolute path of the file:

private function getFilePathCacheKey(string $filePath): string
{
    return $this->fileHasher->hash($this->resolvePath($filePath) . $this->scopeSuffix);
}

private function resolvePath(string $filePath): string
{
    $realPath = realpath($filePath);
    // ...
    return $realPath;
}

The path is hashed into the cache file's name, so the cache is bound to one location on disk. Move the project - a second git worktree, a CI checkout, a container mount - and the cache is 100% misses while containing nothing that could be rewritten to fix it.

Measurements

A 12 762-file project, 14 cores, PHP 8.5.10.

Scenario Wall time
fresh checkout, empty cache 224 s
same checkout, warm cache 5 s
fresh checkout, cache copied from another checkout of the same commit 247 s (291 MB copied for nothing)

For comparison, the same experiment with the other two tools in the same toolchain, copying their caches into the same fresh checkout:

Tool cold seeded from another checkout
Pint (PHP-CS-Fixer) 105 s 2.7 s
PHPStan 43 s 4.4 s
Rector 224 s 247 s

Rector's cache records nothing about the environment. Grepping all 12 761 entries of a populated tmp/rector finds zero references to a PHP version, an extension list or an OS - each entry is just a content hash. The absolute path is the only thing standing between that cache and reuse somewhere else.

Proposal

Key on the path relative to the project root and re-absolutize on read, as PHPStan does.
Two honest caveats:

  1. Existing caches invalidate once on upgrade.
  2. Files outside the project root (if any can reach the detector) need a defined behaviour - PHPStan's transformer leaves an already-absolute path untouched, which also keeps old-format caches readable.

I am happy to send a PR if you agree with the direction. I would rather hear which shape you want (anchor directory as a constructor dependency vs resolving it from the config) than guess and have it rewritten.

Lenguaje dominante
PHP
Estrellas
137
Forks
451
Merge medio
7 h 11 min
PR fusionados (30 d)
129

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de rectorphp/rector-src

Todos los issues de rectorphp/rector-src

Issues similares

Más issues de PHP

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.