2.8.1: ExecJS.compile consistently exits 1 in one environment and 0 elsewhere.
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Aptitud para principiantes
- 35/100
Línea de trabajo
Start with the reproduction script and the ExecJS entry points in lib/execjs/module.rb, runtime.rb, and external_runtime.rb, then compare the behavior introduced by a6abf130c721ca6ec05cfc7ed79cf2e87a7dcc35 with 2.8.0. Reproduce the exit-status difference using Node 12.21.0 in the affected RHEL environment and verify that compilation succeeds with exit code 0 without regressing the hanging-process fix.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
I have a few environments I'm testing execjs's compile in combination with uglifier and have a strange problem that happens consistently in one environment but not elsewhere. I have minimized the problem to this commit: a6abf130c721ca6ec05cfc7ed79cf2e87a7dcc35 released in 2.8.1 and can reliably recreate it with this script:
require 'bundler/inline'
gemfile do
source 'http://rubygems.org'
gem 'execjs', "=2.8.1"
gem 'uglifier', "=3.0.4"
end
require 'uglifier'
puts "Uglifier: #{Uglifier::VERSION}"
puts "ExecJS: #{ExecJS::VERSION}"
puts "Running test..."
ExecJS.compile(File.read(Uglifier::SourceMapPath)); nil
puts $?
In the bad environment, I'm seeing that this exits with 'ok' but with exit code 1:
Uglifier: 3.0.4
ExecJS: 2.8.1
Running test...
Traceback (most recent call last):
7: from XXX/gems/execjs-2.8.1/lib/execjs/module.rb:27:in `compile'
6: from XXX/gems/execjs-2.8.1/lib/execjs/runtime.rb:72:in `compile'
5: from XXX/gems/execjs-2.8.1/lib/execjs/runtime.rb:72:in `new'
4: from XXX/gems/execjs-2.8.1/lib/execjs/external_runtime.rb:14:in `initialize'
3: from XXX/gems/execjs-2.8.1/lib/execjs/external_runtime.rb:39:in `exec'
2: from XXX/gems/execjs-2.8.1/lib/execjs/external_runtime.rb:219:in `exec_runtime'
1: from (execjs):1
ExecJS::RuntimeError (["ok"])
pid 134 exit 1
When I try to recreate this issue in other environments with 2.8.1, it exits correctly with exit code 0.
I determined it was this change: a6abf130c721ca6ec05cfc7ed79cf2e87a7dcc35 by testing this bad environment with execjs 2.8.0 and 2.7.0 without changing anything else and they both exit with exit code 0 as expected:
Uglifier: 3.0.4
ExecJS: 2.7.0
Running test...
pid 364 exit 0
Uglifier: 3.0.4
ExecJS: 2.8.0
Running test...
pid 249 exit 0
I'm using node 12.21.0 and it works on OSX and RHEL 8.4 and debian. The bad environment is also RHEL 8.4 based with a very similar setup as the working one.
It looks like we're explicitly calling process.exit() to avoid it hanging: c5fd11d7b0338ae7779f69a293964f3440ee3787. The docs say:
Rather than calling process.exit() directly, the code should set the process.exitCode and allow the process to exit naturally by avoiding scheduling any additional work for the event loop
The commit for 2.8.1 is such a minor change. I don't know if the process isn't gracefully terminating or some other low level error is happening but I cannot get more information to determine why this exits 1, which in turn makes execjs believe it failed. I've tried getting more output from node but the following options didn't give me anything extra:
--report-uncaught-exception
--report-on-fatalerror
Do you have any ideas on things I can try? Thanks!
- Lenguaje dominante
- Ruby
- Estrellas
- 578
- Forks
- 286
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Sin plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de rails/execjs
-
Runtime stderr is missing from ruby error messagePosiblemente ocupada @arpitjain099 la tomó hace 122 días. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 45/100
-
Dificultad 3/5 1-2 días Aptitud para principiantes 35/100
-
Dificultad 4/5 3-5 días Aptitud para principiantes 25/100
-
Dificultad 4/5 3-5 días Aptitud para principiantes 25/100
-
Dificultad 4/5 3-5 días Aptitud para principiantes 10/100
Todos los issues de rails/execjs
Issues similares
-
Použiť Redis pre ActionCableAbierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 65/100
slovensko-digital/autogram-portal#392 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 65/100
voxpupuli/puppet-quadlets#122 · 5 comentarios ·
Los mantenedores suelen responder en 1 día
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 82/100
TheOdinProject/curriculum#31452 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
-
revoir les metions de la DGEAbierto
Dificultad 1/5 Menos de una hora Aptitud para principiantes 72/100
betagouv/conseillers-entreprises#4720 ·
Los mantenedores suelen responder en 3 días