[RISC-V64/Linux] ftruncate succeeds on an O_RDONLY descriptor

Abierto
#1,687 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
66/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
python

Línea de trabajo

Start in the ftruncate handler in qiling/os/posix/syscall/unistd.py, which passes the host path to a path-based truncate helper. Check how the guest fd is mapped to its open file and whether its access mode is available there. Reproduce with the C probe from the issue on an RV64 rootfs. Done when ftruncate on an O_RDONLY descriptor returns EBADF and leaves the file size unchanged.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Describe the bug

On an RV64 Linux guest, ftruncate(fd, 0) succeeds when fd was opened with O_RDONLY, and the file is truncated. Linux returns EBADF for ftruncate on a descriptor that is not open for writing and leaves the file unchanged.

Sample Code

Create rootfs/scratch with the contents abc, then run this static RV64 guest:

#include <errno.h>
#include <fcntl.h>
#include <stdio.h>
#include <sys/stat.h>
#include <unistd.h>

int main(void)
{
    int fd = open("/scratch", O_RDONLY);
    if (fd < 0)
        return 2;

    errno = 0;
    int rc = ftruncate(fd, 0);
    int err = errno;
    struct stat st;
    if (stat("/scratch", &st) != 0)
        return 3;

    printf("rc=%d errno=%d size=%ld\n", rc, err, (long)st.st_size);
    return 0;
}
riscv64-linux-gnu-gcc -static -O2 -Wall -Wextra ftruncate_probe.c -o probe.elf
mkdir -p rootfs
printf abc > rootfs/scratch
cp probe.elf rootfs/probe.elf
python3 -c 'from qiling import Qiling; Qiling(["./rootfs/probe.elf"], "./rootfs").run()'

Linux returns -1/EBADF and leaves the size at 3. Qiling returns success and the size becomes 0.

Expected behavior

Qiling should check that the guest descriptor is open for writing before changing the file length. The current ftruncate handler passes the host path to a path-based truncate helper, which does not check the guest descriptor's access mode.

Additional context

Reproduced on Qiling v1.4.11 and the development snapshot for RV64 Linux. Current dev commit 23ad4fd369a360ad7992d90cb7577f0241061c2b still has the same ftruncate path. The current source was checked statically; full upstream CI has not been run.

Lenguaje dominante
Python
Estrellas
6.2k
Forks
806
Métricas de merge de PR
Sin PR fusionados en 30 d

Preparar el entorno

  • Incluye un Dockerfile o un archivo de Docker Compose
  • Tiene una plantilla de pull request
  • Sin guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de qilingframework/qiling

Todos los issues de qilingframework/qiling

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.