Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

no_rope_layer_interval is declared but never applied, and SmolLM3's own config sets it

Abierto
  • ¿Algo no está bien?
#22,043 2 comentarios 0 reacciones 2 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

@MukeshK17 ya está trabajando en esto.

Desde el 24/8/2026.

  • #22177 de @MukeshK17 — abierto

Evaluación

Este issue todavía no se ha evaluado.

Descripción

module: llm triaged

ModelArgs declares no_rope_layer_interval, and examples/models/smollm3/3b_config.json sets it to 4, but nothing on the examples/models/llama export path reads it. On main (e4576d0) the name appears exactly once across the 32 Python files of that path:

examples/models/llama/model_args.py:119:    no_rope_layer_interval: Optional[int] = (

__post_init__ does not touch it, and Attention.forward applies rope unconditionally (attention.py:529, attention.py:563) with no layer-index test. The two places that do honour it are backends/mlx/llm/et_attention.py:111 and examples/qualcomm/oss_scripts/llama/model/static_llama.py:288.

So a model that alternates RoPE and NoPE layers exports without complaint and comes out with rope on every layer.

Reproducing

examples/models/smollm3/3b_config.json and examples/models/smollm3/convert_weights.py are both in the tree, so SmolLM3-3B looks ready to export. Converting its weights and exporting through export_llm with that params json (XNNPACK, 8da4w + 8-bit embedding, 1852.2 MB) gives a .pte that loads and runs, then does this:

prompt: <|im_start|>user\nWhat is the capital of France?<|im_end|>\n<|im_start|>assistant\n
output: Okay, so you want to know what what what what what what what what what what what
        what what what what what what what what what what what what what what what what

prompt: <|im_start|>user\nWhat is 17 times 4?<|im_end|>\n<|im_start|>assistant\n
output: I think you are looking for an answer that can be given that can be be be be be
        determ determ determ determ determ determ determ determ determ determ#ae determ#

It starts as English and collapses, which is what a positional-encoding mismatch looks like: the first few tokens are fine and the drift grows with position.

What would help

Either implement the interval on this path, or reject a params json that sets a field the chosen backend does not implement. The silent version is the expensive one — the export succeeds, the file is the right size, and the model is simply a different model.

Measured with the executorch 1.4.0 wheel; the code paths quoted above are byte-identical on main at e4576d0.

cc @larryliu0820 @mergennachin @cccclai @helunwencser @jackzhxng @digantdesai

Lenguaje dominante
Python
Estrellas
5.1k
Forks
1.2k
Merge medio
2 d 9 h
PR fusionados (30 d)
661

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de pytorch/executorch

Todos los issues de pytorch/executorch

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.