Feedback
@goldsborough ya está trabajando en esto.
Desde el 8/10/2018.
Evaluación
Este issue todavía no se ha evaluado.
Descripción
Hey, I just did a simple integration of libtorch as an addon for nodejs. The API worked very nice and I really enjoyed the design, it's very well done ! I'm adding in this issue some feedbacks (don't know if here is the best place, but here you go):
- The
torch::jit::loadisn't exposed by just adding thetorch/torch.hheader, you have to include thetorch/script.has well, don't know if it is intentional but it took me some time to find the right header, maybe a documentation improvement could help; - There are some local paths hardcoded into the ATen cmake files, such as in
share/cmake/ATen/ATenConfig.cmake:/Users/administrator/nightlies/2018_10_01/wheel_build_dirs/libtorch_2.7/pytorch/torch/lib/tmp_install/include; - Documentation is still missing some parts, especially regarding loading TorchScript, etc. Given that a lot of people will start to use the libtorch, I would be nice to have a expanded documentation on ATen/Torch API with some examples (I can contribute as well);
- Problem when seeing the docs for the
torch::jit::load(https://pytorch.org/cppdocs/api/function_namespacetorch_1_1jit_1ace2c44fb8af5905ae17834e81086b8a3.html#exhale-function-namespacetorch-1-1jit-1ace2c44fb8af5905ae17834e81086b8a3) - Many broken broken in the initial page of the docs (
torch::nn,torch::optim,torch::data,torch::serialize,torch::jitandtorch::python)
This is what I remember, if I see anything else I'll add it here as well.
- Lenguaje dominante
- HTML
- Estrellas
- 256
- Forks
- 37
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Guía de contribución
No hay ninguna guía de contribución indexada para este repositorio
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de pytorch/cppdocs
-
Dificultad 3/5 1-2 días Aptitud para principiantes 35/100
-
Direct Installation command Abierto
Dificultad 3/5 1-2 días Aptitud para principiantes 25/100
-
Compile with tensorRT error? Abierto
Dificultad 4/5 3-5 días Aptitud para principiantes 25/100
-
Dificultad 3/5 1-2 días Aptitud para principiantes 20/100
-
Dificultad 4/5 3-5 días Aptitud para principiantes 20/100