Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

spec markdown lint tests fail with mdl >= 0.12

Abierto
  • ¿Algo no está bien?
#386 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
2/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
55/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Estancado
Stack tecnológico
ruby
Área
testing-qa

Línea de trabajo

Comienza con el cambio temporal de versión de mdl en el Gemfile y los ejemplos que fallan en spec/unit/puppet-strings/markdown_spec.rb. Ejecuta las specs de renderizado de Markdown con mdl 0.12 o posterior y, después, verifica que los fixtures renderizados no produzcan errores de lint y que las pruebas de RSpec pasen.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

bug

Describe the Bug

When using mdl >= 0.12, the spec tests in spec/unit/puppet-strings/markdown_spec.rb fail as follows:

Failures:                                                                                                                                             
                                                                                                                                                      
  1) PuppetStrings::Markdown rendering fixtures does not generate markdown lint errors from the rendered markdown                                     
     Failure/Error: expect(output).to have_no_markdown_lint_errors                                                                                    
       expected that "# Reference\n\n<!-- DO NOT EDIT: This document was generated by Puppet Strings -->"... would have no markdown lint errors but go
t 593: MD012 Multiple consecutive blank lines:                                                                                                        
     Shared Example Group: "markdown lint checker" called from ./spec/unit/puppet-strings/markdown_spec.rb:56                                         
     # ./spec/unit/puppet-strings/markdown_spec.rb:48:in `block (4 levels) in <top (required)>'                                                       
                                                                                                                                                      
  2) PuppetStrings::Markdown rendering fixtures with Puppet Plans does not generate markdown lint errors from the rendered markdown                   
     Failure/Error: expect(output).to have_no_markdown_lint_errors                                                                                    
       expected that "# Reference\n\n<!-- DO NOT EDIT: This document was generated by Puppet Strings -->"... would have no markdown lint errors but go
t 631: MD012 Multiple consecutive blank lines:                                                                                                        
     Shared Example Group: "markdown lint checker" called from ./spec/unit/puppet-strings/markdown_spec.rb:105                                        
     # ./spec/unit/puppet-strings/markdown_spec.rb:48:in `block (4 levels) in <top (required)>'                                                       
                                                                                                                                                      
  3) PuppetStrings::Markdown rendering fixtures with Puppet Data Types does not generate markdown lint errors from the rendered markdown
     Failure/Error: expect(output).to have_no_markdown_lint_errors      
       expected that "# Reference\n\n<!-- DO NOT EDIT: This document was generated by Puppet Strings -->"... would have no markdown lint errors but go
t 669: MD012 Multiple consecutive blank lines: 
     Shared Example Group: "markdown lint checker" called from ./spec/unit/puppet-strings/markdown_spec.rb:119
     # ./spec/unit/puppet-strings/markdown_spec.rb:48:in `block (4 levels) in <top (required)>'

This is due to mdl changing the default indentation from 2 spaces to 3 spaces for the rule MD007. See https://github.com/markdownlint/markdownlint/commit/67f8312aae3390df77f82c8054560bc0e8e27169

Expected Behavior

The rspec tests should pass.

Steps to Reproduce

  1. Clone puppet-strings 4.2.1
  2. Update the Gemfile temporarily to install mdl 0.12 or newer
  3. Update installed gems in bundle
  4. Use bundle to run the spec tests

Environment

  • Version: 4.2.1
  • OS: Debian sid
Lenguaje dominante
Ruby
Estrellas
90
Forks
92
Merge medio
13 h 23 min
PR fusionados (30 d)
2

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de puppetlabs/puppet-strings

Todos los issues de puppetlabs/puppet-strings

Issues similares

Más issues de Ruby

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.