pe_patch fact generation listing duplicates causing fatal puppet errors
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Aptitud para principiantes
- 45/100
Línea de trabajo
Comience con pe_patch_fact_generation.sh y reproduzca la generación de facts en un nodo en el que el mismo paquete esté disponible desde dos repositorios habilitados. Compruebe la salida generada de pe_patch::package_updates y las declaraciones de recursos de Puppet resultantes; el trabajo estará terminado cuando las entradas de paquetes duplicadas ya no provoquen la declaración duplicada fatal indicada.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Affected Puppet, Ruby, OS and module versions/distributions
Puppet: 7.34.0 and 8.13.1
Running in PE v2023.8.4
OS: RHEL 8
How to reproduce (e.g Puppet code you use)
Have a package update available in two different simultaneously enabled repos available to yum/dnf. Allow pe_patch_fact_generation.sh to run on the node. Attempt to run puppet with the patching modules that use the fact generated by the above script.
What are you seeing
The generated puppet fact pe_patch::package_updates will list the available updates twice as they appear in two repos as the above script does not attempt any deduplication of data. This causes a duplicate resource declaration in puppet as it appears the PE modules which consumes pe_patch::package_updates, which then causes a fatal error preventing any puppet configuration from being applied. Included that needed to clean up the duplicate repos...
What behaviour did you expect instead
Obviously, having repos with duplicate packages in is not ideal, so this can be fixed by rationalising the repo config on the affected hosts. However, I would hope that this could be accounted for by deduplicating the list of available updates, or at worst handling this 'error' condition in a non-fatal way. Yum will quite happily update a package which appears in two separate repos by syntactically sorting the repos and using the first. But in this situation this duplication of package names in the pe_patch fact completely breaks puppet until the updates are manually applied, then the patching module works - but only because there are no longer any updates. Any new updates added to both repos will then break puppet again preventing the update.
Output log
# puppet facts pe_patch
{
"pe_patch": { ...
"package_updates": [
"fping.x86_64",
"fping.x86_64",
"haveged.x86_64",
"haveged.x86_64",
"libbsd.x86_64",
"libbsd.x86_64",
....
On a node, this causes the patching module in puppet to fatally error with:
Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Resource Statement, Duplicate declaration: Package[fping.x86_64] is already declared at (file: /etc/puppetlabs/puppetserver/code/environments/.../modules/patching/manifests/patch.pp, line: 21); cannot redeclare (file: /etc/puppetlabs/puppetserver/code/environments/.../modules/patching/manifests/patch.pp, line: 21)
Any additional information you'd like to impart
I'd quite happily accept that this isn't exactly a bug in the fact generation script so could be better described as a feature request to resolve a fatal error condition caused by non-optimal repo creation. Not trying to point fingers, but if it's known the output of a fact is being consumed directly to generate identically named puppet resources, and we know that such resources have to be unique, it may be reasonable to ensure the list cannot contain duplicates.
- Lenguaje dominante
- Ruby
- Estrellas
- 4
- Forks
- 1
- Merge medio
- 44 min
- PR fusionados (30 d)
- 1
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Sin plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de puppetlabs/pe_patch
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 50/100
puppetlabs/pe_patch#98 ·
-
Allow disabling single checksAbierto
Dificultad 4/5 3-5 días Aptitud para principiantes 35/100
puppetlabs/pe_patch#97 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 48/100
puppetlabs/pe_patch#93 ·
Todos los issues de puppetlabs/pe_patch
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
Homebrew/homebrew-cask#293134 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
notch8/iiif_print#430 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 65/100
Los mantenedores suelen responder en 1 día
-
ActionText::Content#to_markdown: <br> in a table cell and empty <tr> produce malformed Markdown tablesPosiblemente ocupada @azmi2409 la tomó hoy. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 66/100
Los mantenedores suelen responder en 2 días