Content app answers 404 instead of 502 when the remote of on-demand content is unavailable
Los mantenedores suelen responder en 1 día
Evaluación
- Dificultad
- 3/5
- Tiempo estimado
- Medio día
- Aptitud para principiantes
- 66/100
Línea de trabajo
Start in Handler._stream_content_artifact in the content app, where the loop over RemoteArtifact downloads ends by raising HTTPNotFound; SKIPPABLE_EXCEPTIONS and REMOTE_CONTENT_FETCH_FAILURE_COOLDOWN also govern that loop. Run test_delete_remote_on_demand, test_remote_artifact_url_update and test_remote_content_changed_with_on_demand, which must keep passing as 404. Done means a connection failure or 5xx from the remote yields 502 while the other failure cases stay 404, and the open question about 429 is settled.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Version
pulpcore 3.119.2 with pulp_file, installed from source with oci-env. The behaviour is the same on main (475caac) and dates back to 3.0.0.
Describe the bug
When a ContentArtifact has no Artifact (on-demand or streamed content, or content whose artifact was reclaimed), the content app streams it from its RemoteArtifact objects. When none of them can be fetched, Handler._stream_content_artifact raises HTTPNotFound whatever the reason: a remote that cannot be reached or answers with a server error gets the same 404 as content missing upstream.
The docstring of _stream_content_artifact contradicts itself: its description says that "if all RemoteArtifact downloads raise exceptions, an HTTP 502 error is returned to the client", while its Raises section, like the code, gives HTTPNotFound. It has been so since 3.0.0; the user documentation does not mention this case.
Clients then take a transient upstream outage for missing content. For example, pip retries 500, 502, 503, 520 and 527 but not 404, so with pulp_python packages synced with the default on_demand policy, a short outage fails the install at once, with a 404 pointing at the package.
To Reproduce
- Sync a file repository with the
on_demandpolicy from a fixture server, and distribute it. - Make the fixture server unavailable: close the connections, or answer 503 for the files.
- Download a file from the distribution: 404 Not Found.
Expected behavior
502 Bad Gateway when at least one remote could not be reached or answered with a server error (5xx). 404 for any other failure, as today, e.g. no RemoteArtifact, remotes answering 404, 410 or another 4xx, UnsupportedDigestValidationError, RemoteArtifact objects in their failure cooldown (REMOTE_CONTENT_FETCH_FAILURE_COOLDOWN).
Open question: should a 429 Too Many Requests from the remote, which is transient too, also give a 502?
Additional context
- The tests asserting a 404 (
test_delete_remote_on_demand,test_remote_artifact_url_update,test_remote_content_changed_with_on_demand) cover those other cases and pass unchanged with the fix. - pulp_container calls
_stream_content_artifactdirectly for registry blobs, which would get a 502 too. None of the active content plugins (pulp_ansible, pulp_container, pulp_deb, pulp_gem, pulp_hugging_face, pulp_maven, pulp_npm, pulp_python, pulp_r, pulp_rpm, pulp_rust, pulp_trustify, pulp_workflow) nor pulp-service catches this 404 or asserts it in its tests. - Nothing in pulpcore catches this 404 to fall back elsewhere: the content cache stores neither response, and the instrumentation middleware records the status, so the
content.request_durationmetrics and deployments alerting on the 5xx rate of the content app will count upstream outages there. TimeoutException, raised by the downloader on timeouts, is not one of the exceptions skipped by this loop (SKIPPABLE_EXCEPTIONS) and is left unchanged.
I reproduced it in an oci-env container with pulpcore 3.119.2 and pulp_file installed from source: once the remote closed the connections or answered 503, the distribution answered 404 for the on-demand file.
Drafted with AI assistance, reviewed by me.
- Lenguaje dominante
- Python
- Estrellas
- 606
- Forks
- 174
- Merge medio
- 16 h 44 min
- PR fusionados (30 d)
- 107
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de pulp/pulpcore
-
Reclaim Space Server ErrorAbiertoIssue
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
Los mantenedores suelen responder en 1 día
-
Feature
Dificultad 2/5 1-3 horas Aptitud para principiantes 62/100
pulp/pulpcore#5802 · 10 comentarios ·
Los mantenedores suelen responder en 1 día
-
Dificultad 4/5 3-5 días Aptitud para principiantes 28/100
pulp/pulpcore#8214 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
Performance Task Triage-Needed
Dificultad 5/5 Más de una semana Aptitud para principiantes 25/100
pulp/pulpcore#8206 · 3 comentarios · 1 reacción ·
Los mantenedores suelen responder en 1 día
-
Issue Triage-Needed
Dificultad 3/5 1-2 días Aptitud para principiantes 35/100
Los mantenedores suelen responder en 1 día
Todos los issues de pulp/pulpcore
Issues similares
-
documentation good first issue
Dificultad 2/5 Medio día Aptitud para principiantes 72/100
sujithputta02/Esapay#13 ·
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
Los mantenedores suelen responder en 1 día
-
Flaky: credential-proxy admission metric test asserts a wall-clock bound it does not establishAbiertoneeds-triage
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
gke-labs/kube-agents#3277 ·
Los mantenedores suelen responder en 1 día
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
jbacalso24/mimry#291 ·
Los mantenedores suelen responder en 1 día
-
good first issue
Dificultad 2/5 Menos de una hora Aptitud para principiantes 82/100
eli-alvarado/us-watchlist-alerts#14 ·
Los mantenedores suelen responder en 1 día