Add error-path tests for HybridDecrypter.Decrypt in the crypto package

Abierto Apto para principiantes
  • ¿Algo no está bien?
#7,090 4 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 2 días

@gangadhar-res ya está trabajando en esto.

Desde el 12/8/2026.

Evaluación

Dificultad
2/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
72/100
Tipo de issue
Nueva funcionalidad
Claridad
Bien especificado
Estado de actividad
Tranquilo
Stack tecnológico
go
Área
security

Línea de trabajo

Comienza con Decrypt de hybrid.go y el TestHybridEncryptDecrypt existente; después revisa TestNewAESEncryptDecrypterInvalidKey y TestAESEncryptDecrypt para conocer el estilo testify del paquete y la configuración de las claves de testdata. Añade cobertura para las cinco rutas de error indicadas y ejecuta las pruebas del paquete crypto; se considera terminado cuando el base64 no válido, las longitudes malformadas, la manipulación de RSA y la manipulación de AES-GCM devuelven errores.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

What would you like to be added:

I'd like to add unit tests for the error paths in HybridDecrypter.Decrypt(). Right now the only test we have (TestHybridEncryptDecrypt) just tests the happy path — encrypt something valid, decrypt it back, make sure it matches. But the Decrypt function has around 5 different ways it can fail, and none of them are tested.

My plan is to add a table-driven test that covers:

  1. Passing in garbage that isn't valid base64
  2. Passing in data that's too short to even read the RSA length header
  3. Passing in data where the declared RSA length is bigger than what's actually there
  4. Tampering with the RSA ciphertext portion so RSA OAEP decryption fails
  5. Tampering with the AES-GCM ciphertext portion so the authentication check fails — this is the one that worries me most because if someone accidentally breaks that GCM auth check, tampered secrets would just pass through silently

I've already looked at how the rest of the crypto package does tests (TestNewAESEncryptDecrypterInvalidKey, TestAESEncryptDecrypt, etc.) and I'll match that same style — testify/require and testify/assert, same-package tests, reading keys from testdata/.

Why is this needed:

I was reading through hybrid.go and noticed the Decrypt function has quite a few places where it can return errors, but none of them have tests. The one that really stood out to me is the AES-GCM authentication check on line 143 (aed.Open). That's the function that verifies the ciphertext hasn't been tampered with. If someone accidentally broke that check in a refactor, we might not catch it because the only test just tests valid data.

Since this crypto code is what powers PipeCD's sealed secrets feature, I think it's worth having these tests in place. Better to catch a regression early than to have tampered secrets slip through.

If this approach aligns with what you had in mind, I can go ahead and put together the implementation. If you'd prefer a different structure or have additional cases you want covered, just let me know.... happy to adjust!

Lenguaje dominante
Go
Estrellas
1.4k
Forks
391
Merge medio
4 d 1 h
PR fusionados (30 d)
58

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de pipe-cd/pipecd

Todos los issues de pipe-cd/pipecd

Issues similares

Más issues de Go

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.