Legacy v0 tool installer hardcodes amd64 binaries, breaking darwin/arm64 hosts

Abierto
  • ¿Algo no está bien?
#7,005 1 comentario 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 2 días

@singhharsh1708 ya está trabajando en esto.

Desde el 6/9/2026.

  • #7006 de @rootp1 — cerrado sin fusionar

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
78/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
go, helm, kubernetes, terraform
Área
devops, tooling

Línea de trabajo

Empieza por pkg/app/piped/toolregistry/tool_darwin.go e install.go y después compara la plantilla de arquitectura en pkg/app/pipedv1/plugin/kubernetes/toolregistry/scripts.go y pkg/app/pipedv1/cmd/piped/grpcapi/tool_registry.go. Ejecuta las pruebas específicas de Kubernetes, incluidas helm_test.go y kustomize_test.go, y añade cobertura para los scripts renderizados en una arquitectura distinta de amd64. La tarea estará terminada cuando los cuatro scripts de instalación heredados usen la arquitectura del host y las pruebas pasen.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

What happened:

The legacy piped v0 tool registry hardcodes amd64 in every Darwin (and Linux) install script for kubectl, kustomize, helm, and terraform. On an Apple Silicon (darwin/arm64) host, toolregistry.InitDefaultRegistry/installKubectl/installKustomize/installHelm/installTerraform in pkg/app/piped/toolregistry/tool_darwin.go unconditionally download the darwin/amd64 build of each tool, so the resulting binaries cannot execute natively on arm64 hosts.

This affects both local development and any test suite that exercises these code paths.

What you expected to happen:

The legacy v0 tool registry should resolve the host OS/architecture dynamically (the same way the newer pipedv1 tool registries already parameterize {{ .Os }} / {{ .Arch }} in their install scripts), so it downloads a binary compatible with the host architecture.

How to reproduce it:

  1. Use a darwin/arm64 machine (e.g. Apple Silicon Mac).
  2. From the repository root, run: 
    go test ./pkg/app/piped/platformprovider/kubernetes/...
  3. Observe failures such as: 
    fork/exec /tmp/piped-bin/helm: bad CPU type in executable
    in helm_test.go and kustomize_test.go, because the previously-downloaded darwin/amd64 helm/kustomize binaries cannot run on arm64.
  4. Inspect pkg/app/piped/toolregistry/tool_darwin.go (lines ~17-55) and confirm every download URL is pinned to darwin/amd64, regardless of runtime.GOARCH.

Environment:

  • piped version: repository checkout (master)
  • control-plane version: not applicable
  • Others: reproduced on macOS arm64 (Apple Silicon); confirmed via static inspection that pkg/app/piped/toolregistry/tool_darwin.go and pkg/app/piped/toolregistry/install.go never reference runtime.GOARCH, unlike the pipedv1 tool registries (e.g. pkg/app/pipedv1/plugin/kubernetes/toolregistry/scripts.go, pkg/app/pipedv1/cmd/piped/grpcapi/tool_registry.go) which already template {{ .Os }}/{{ .Arch }} from runtime.GOOS/runtime.GOARCH.

Suspected root cause:

The older v0 tool registry (pkg/app/piped/toolregistry) uses static, OS-specific install scripts written before Apple Silicon support was considered, while the pipedv1 tool registries were already generalized to resolve the host architecture at install time.

Proposed direction:

Parameterize the Darwin (and Linux) install scripts in pkg/app/piped/toolregistry with the host architecture (runtime.GOARCH), following the pattern already used by the pipedv1 tool registries, and add regression coverage asserting the rendered install scripts reference the host architecture rather than a hardcoded value.

Acceptance criteria:

  • Helm, kubectl, kustomize, and Terraform install scripts reference the host architecture instead of a hardcoded amd64.
  • The legacy (pkg/app/piped/toolregistry) and pipedv1 tool registries no longer diverge on architecture handling.
  • Focused tests cover the rendered install scripts for a non-amd64 architecture.
Lenguaje dominante
Go
Estrellas
1.4k
Forks
391
Merge medio
4 d 1 h
PR fusionados (30 d)
58

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de pipe-cd/pipecd

Todos los issues de pipe-cd/pipecd

Issues similares

Más issues de Go

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.