[Bug]: A child run started with `t3 thread send` from a shell never notifies the parent

Abierto Apto para principiantes
  • ¿Algo no está bien?
#33,432 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
2/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
74/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
typescript
Área
backend

Línea de trabajo

Empieza en apps/server/src/orchestration-v2/Orchestrator.ts, en recordSubagentFollowup, y luego lee los casos y las pruebas relacionados en DelegatedCompletionDelivery.test.ts. El issue describe un cambio propuesto de una línea en una condición y una prueba que reproduce la ausencia del seguimiento. El trabajo está terminado cuando la prueba de regresión falla antes del cambio y pasa después, mientras que los envíos de otro hilo siguen excluidos.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Before submitting
  • I searched existing issues and did not find a duplicate.
  • I included enough detail to reproduce or investigate the problem.
Area

apps/server

Steps to reproduce
  1. In thread P, call delegate_task to start child C. Let its first run finish.
  2. With P idle, run t3 thread send <C thread id> - from a shell with a short prompt.
  3. Wait for C's new run to finish.
Expected behavior

P gets a completion notice and a new run, as it does for a later run that P sends itself with t3_thread_send.

Actual behavior

P gets no notice and no run until something else wakes it. From T3's state DB (read-only), 2026-10-25 to 2026-11-09 13:44 UTC: 731 completed child runs were started this way, and 420 ended with the parent idle and no parent run within 10 s. Of 433 idle-parent runs that did get a delegated task, 2 had no parent run within 10 s.

Root cause: recordSubagentFollowup (apps/server/src/orchestration-v2/Orchestrator.ts) creates the follow-up task, which carries the notice, when the send is a notification, has createdBy: user, continues a usage-limit stop, or has senderThreadId equal to the parent. t3 thread send signs in as an MCP client with no thread, so its send is createdBy: agent with no senderThreadId and matches none of those. The gate is the same in 0.1.8-nightly.20261109.4399 and main (4f0b74e). #31707 reports the same symptom for remote children.

Proposed fix: count a send with no sender thread like a user send: (command.senderThreadId ?? parentThreadId) !== parentThreadId in that gate. A send from a different thread stays excluded. A patch is ready: one line plus a test in DelegatedCompletionDelivery.test.ts that fails before and passes after. Sending T3CODE_THREAD_ID from the CLI would hit assertLiveCaller, which refuses a thread with no active run, and the parent is idle by then.

Impact

Major degradation or frequent failure

Version or commit

0.1.8-nightly.20261105.4218

Environment

macOS 26.6.1 arm64, Claude provider. Checked with the new unit test and with t3_thread_send through the MCP toolkit with no thread scope against a replayed Codex provider (no follow-up task before, one after). The t3 binary and a live provider were not run.

Lenguaje dominante
TypeScript
Estrellas
24.8k
Forks
6.4k
Merge medio
8 h 26 min
PR fusionados (30 d)
133

Preparar el entorno

Abrir en Codespaces

Inicia el contenedor de desarrollo del proyecto en tu navegador, con tu propia cuenta de GitHub.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de pingdotgg/t3code

Todos los issues de pingdotgg/t3code

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.