Replace VoicingManager.speakIgnoringEnabled with a Property controlling speech
Nadie ha tomado este issue todavía.
Evaluación
Este issue todavía no se ha evaluado.
Descripción
It is confusing that the voicingManager.enabledProperty can have a value of false but there can still be speech with speakIgnoringEnabled. A better way would be to provide a separate Property to control speech output while making it so that whenever voicingManager.enabledProperty is false there can be no speech. Here is some scratch illustrating the change we are thinking of.
Index: joist/js/audioManager.js
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/joist/js/audioManager.js b/joist/js/audioManager.js
--- a/joist/js/audioManager.js (revision ddcffa71993bd7e06725b30f5a394124e7cff693)
+++ b/joist/js/audioManager.js (date 1634927385639)
@@ -135,6 +135,7 @@
sim.isConstructionCompleteProperty,
sim.browserTabVisibleProperty,
sim.activeProperty,
+ this.simVoicingEnabledProperty, // passed to the PreferenceDialog, field on AudioManager
sim.isSettingPhetioStateProperty,
this.audioEnabledProperty
], ( simConstructionComplete, simVisible, simActive, simSettingPhetioState, audioEnabled ) => {
Index: scenery/js/accessibility/voicing/voicingManager.js
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/scenery/js/accessibility/voicing/voicingManager.js b/scenery/js/accessibility/voicing/voicingManager.js
--- a/scenery/js/accessibility/voicing/voicingManager.js (revision 414d8cf0bf3cdabc1a9c8e6eb6b7e091ae8369cf)
+++ b/scenery/js/accessibility/voicing/voicingManager.js (date 1634927277241)
@@ -382,8 +382,8 @@
*
* @param {Utterance} utterance
*/
- speakIgnoringEnabled( utterance ) {
- if ( this.initialized ) {
+ speakIgnoringSpeechAllowed( utterance ) {
+ if ( this.initialized && this.enabledProperty.value ) {
this.requestSpeech( utterance );
}
}
Likely related to https://github.com/phetsims/joist/issues/743 because that will determine where simVoicingEnabledProperty should live. COuld be on the AudioManager, but maybe it should be on a "PreferencesModel", whatever that ends up looking like.
- Lenguaje dominante
- TypeScript
- Estrellas
- 1
- Forks
- 5
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Guía de contribución
No hay ninguna guía de contribución indexada para este repositorio
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de phetsims/utterance-queue
-
Dificultad 5/5 Más de una semana Aptitud para principiantes 30/100
phetsims/utterance-queue#125 ·
-
phetsims/utterance-queue#122 · 2 comentarios · 1 asignado ·
-
Rename UtteranceQueue.addToBack Abierto
phetsims/utterance-queue#121 · 1 asignado ·
-
Remove addToFront Abierto
phetsims/utterance-queue#120 · 1 asignado ·
-
dev:voicing type:i18n
Dificultad 5/5 Más de una semana Aptitud para principiantes 25/100
phetsims/utterance-queue#119 · 1 comentario ·
Todos los issues de phetsims/utterance-queue
Issues similares
-
S: triage
Dificultad 1/5 Menos de una hora Aptitud para principiantes 85/100
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
-
fix(errors): EHOSTUNREACH from a happy-eyeballs connect is reported as a resolver error (STAMP-80) Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 90/100
snapshot-labs/stamp#666 ·
-
fix(api): prevent leaderboard SSE heartbeat from starting after disconnect during initial load Abiertobug
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
GauravKarakoti/SecureFlow#1070 · 1 comentario ·
-
feature:Languages/Translations good first issue ready Web
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
digitalfabrik/integreat-app#4394 ·