Launcher refuses vkd3d-proton next to a game under Proton, where it is the game's Direct3D 12
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Aptitud para principiantes
- 35/100
Línea de trabajo
Read the DXVK/vkd3d-proton rule in wg_core/coexist.cpp and the coexist-core-tests synthetic game fixture described in the issue. The proposed change is already implemented on a fork (commit 376ad4f), so first check whether that work is being submitted as a pull request before duplicating it. Done means tests expect Inform for vkd3d-proton under Wine and Refuse outside Wine, while DXVK remains refused.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
What happens
The coexistence check refuses a game with vkd3d-proton (or DXVK) in its folder. That's right on Windows, where it would replace Windows' Direct3D 12.
Under Proton, vkd3d-proton is the game's Direct3D 12. Until a Proton release ships dxil-spirv PR #362, a self-built vkd3d-proton placed next to the game exe is the only way Model M and RR run on Linux. Proton loads d3d12/d3d12core as native, so the game picks those two DLLs from its folder. So today the launcher refuses exactly the setup Linux players need.
Suggested change (a policy choice, so yours to make)
Under Wine only, report vkd3d-proton next to the game as a note instead of a refusal. Keep refusing DXVK, and keep refusing vkd3d-proton on Windows.
// wg_core/coexist.cpp, in the DXVK / vkd3d-proton rule
if (!f.empty() && t == Tool::Vkd3d && UnderWine())
add(t, Decision::Inform, wstring(ToolName(t)) + L" as " + f[0], f, fpOf(t)->evidence,
L"Under Wine (Proton) vkd3d-proton is the game's Direct3D 12. Left alone; Model M needs a vkd3d-proton whose "
L"dxil-spirv has pull request #362 (AMD's matrix instructions as WrongGPU uses them).");
else if (!f.empty())
add(t, Decision::Refuse, ...); // unchanged
How it was tested
coexist-core-testswith a synthetic game fixture:Game.exeplus ad3d12.dllthat contains a vkd3d-proton marker string.- Under GE-Proton 11-11's Wine it expects Inform; outside Wine it expects Refuse.
- The check failed with the Wine branch taken out.
- A launcher install into a generated test game with vkd3d-proton next to it went through under
proton run. - Not run on Windows.
The change with its tests is in PR #105: commit 1afe78b, which needs only 677af52 (UnderWine()).
Related: #10.
- Lenguaje dominante
- C++
- Estrellas
- 12
- Forks
- 2
- Merge medio
- 3 h 10 min
- PR fusionados (30 d)
- 171
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de phantoslayer21/wronggpu
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
phantoslayer21/wronggpu#275 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
phantoslayer21/wronggpu#274 ·
Los mantenedores suelen responder en 1 día
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
phantoslayer21/wronggpu#241 ·
Los mantenedores suelen responder en 1 día
-
bug build
Dificultad 2/5 1-3 horas Aptitud para principiantes 74/100
phantoslayer21/wronggpu#234 ·
Los mantenedores suelen responder en 1 día
-
Launcher tests: "an older record: update available" fakes a version newer than the test buildAbiertobug build
Dificultad 2/5 1-3 horas Aptitud para principiantes 80/100
phantoslayer21/wronggpu#233 ·
Los mantenedores suelen responder en 1 día
Todos los issues de phantoslayer21/wronggpu
Issues similares
-
ai_p2
Dificultad 2/5 1-3 horas Aptitud para principiantes 80/100
ClickHouse/ClickHouse#132519 ·
Los mantenedores suelen responder en 1 día
-
[Bug]: VST3 getMidiControllerAssignment reads past midiControllerToParameter for program changeAbierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
juce-framework/JUCE#1810 ·
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 82/100
petercorke/robotics-toolbox-python#952 ·
Los mantenedores suelen responder en 1 día
-
NatronRenderer: a Python error in the script (-t / project script) doesn't change the exit statusAbiertofunc:engine type:bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
NatronGitHub/Natron#1276 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 1/5 1-3 horas Aptitud para principiantes 77/100
Los mantenedores suelen responder en 1 día