Launcher refuses vkd3d-proton next to a game under Proton, where it is the game's Direct3D 12

Abierto
#50 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
35/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
cpp, linux
Área
backend

Línea de trabajo

Read the DXVK/vkd3d-proton rule in wg_core/coexist.cpp and the coexist-core-tests synthetic game fixture described in the issue. The proposed change is already implemented on a fork (commit 376ad4f), so first check whether that work is being submitted as a pull request before duplicating it. Done means tests expect Inform for vkd3d-proton under Wine and Refuse outside Wine, while DXVK remains refused.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area: launcher area: linux game-compatibility

What happens

The coexistence check refuses a game with vkd3d-proton (or DXVK) in its folder. That's right on Windows, where it would replace Windows' Direct3D 12.

Under Proton, vkd3d-proton is the game's Direct3D 12. Until a Proton release ships dxil-spirv PR #362, a self-built vkd3d-proton placed next to the game exe is the only way Model M and RR run on Linux. Proton loads d3d12/d3d12core as native, so the game picks those two DLLs from its folder. So today the launcher refuses exactly the setup Linux players need.

Suggested change (a policy choice, so yours to make)

Under Wine only, report vkd3d-proton next to the game as a note instead of a refusal. Keep refusing DXVK, and keep refusing vkd3d-proton on Windows.

// wg_core/coexist.cpp, in the DXVK / vkd3d-proton rule
if (!f.empty() && t == Tool::Vkd3d && UnderWine())
    add(t, Decision::Inform, wstring(ToolName(t)) + L" as " + f[0], f, fpOf(t)->evidence,
        L"Under Wine (Proton) vkd3d-proton is the game's Direct3D 12. Left alone; Model M needs a vkd3d-proton whose "
        L"dxil-spirv has pull request #362 (AMD's matrix instructions as WrongGPU uses them).");
else if (!f.empty())
    add(t, Decision::Refuse, ...);   // unchanged

How it was tested

  • coexist-core-tests with a synthetic game fixture: Game.exe plus a d3d12.dll that contains a vkd3d-proton marker string.
    • Under GE-Proton 11-11's Wine it expects Inform; outside Wine it expects Refuse.
    • The check failed with the Wine branch taken out.
  • A launcher install into a generated test game with vkd3d-proton next to it went through under proton run.
  • Not run on Windows.

The change with its tests is in PR #105: commit 1afe78b, which needs only 677af52 (UnderWine()).

Related: #10.

Lenguaje dominante
C++
Estrellas
12
Forks
2
Merge medio
3 h 10 min
PR fusionados (30 d)
171

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de phantoslayer21/wronggpu

Todos los issues de phantoslayer21/wronggpu

Issues similares

Más issues de C++

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.