Launcher under Wine/Proton writes model paths the game's own prefix can't reach (C: instead of Z:)
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Aptitud para principiantes
- 25/100
Línea de trabajo
The issue says the change and tests already exist on the author's fork in commit 51f28a4, with UnderWine() from commit 35077de as a dependency. Before starting, compare those commits with wg_core/util.cpp and install.cpp and coordinate with the author, who offers to open a PR. If work is still needed, run wg_core_tests under Wine and check that game settings use reachable Z: paths while non-Wine paths remain unchanged.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
What happens
On Linux, players run the launcher under Wine, while Steam's Proton runs each game in a Wine prefix of its own. The launcher writes two paths into the game's settings:
model_dir(wronggpu.ini);rr_model(wronggpu-rr.ini).
Both are written as C:\users\<user>\AppData\Local\WrongGPU\model... paths of the launcher's own prefix. The game's prefix has a different C:, so Model M and Ray Reconstruction find no model there.
Suggested fix
Under Wine, write those two paths as Z: paths: Z: maps the Linux root in every prefix, so the game reaches the same files.
- Wine's
kernel32exportswine_get_unix_file_name, which gives the Linux name of a DOS path. - It fails when more than the last part of the path doesn't exist yet (the RR data's
F\folder before its first conversion). So convert the deepest folder that exists and append the rest. - A
model_dirthe player set stays as it is. - Detecting Wine:
GetProcAddress(GetModuleHandleW(L"ntdll.dll"), "wine_get_version") != nullptr.
The core of it, as I tested it (wg_core/util.cpp):
wstring PathForGamePrefix(const wstring& path) {
if (path.empty() || !UnderWine()) return path;
using UnixNameFn = char*(CDECL*)(const wchar_t*);
auto unixName = reinterpret_cast<UnixNameFn>(reinterpret_cast<void*>(
GetProcAddress(GetModuleHandleW(L"kernel32.dll"), "wine_get_unix_file_name")));
if (!unixName) return path;
wstring head = path, tail;
char* u = nullptr;
while (!(u = unixName(head.c_str()))) { // missing folders: walk up, keep the tail
const size_t cut = head.find_last_of(L"\\/");
if (cut == wstring::npos || cut < 3) return path;
tail = head.substr(cut) + tail;
head.resize(cut);
}
wstring z = L"Z:" + FromUtf8(u) + tail;
HeapFree(GetProcessHeap(), 0, u); // Wine allocates it on the process heap
for (wchar_t& c : z) if (c == L'/') c = L'\\';
return z;
}
install.cpp then writes model_dir = PathForGamePrefix(ModelBaseDir()) under Wine when the player set none, and RrIniText(PathForGamePrefix(RrDataFile())). Outside Wine nothing changes: the function returns the path unchanged.
How it was tested (synthetic data only)
wg_core_testsunder GE-Proton 11-11's Wine (llvm-mingw build): the path names the same file, and a path with two missing folders still becomes aZ:path with its tail kept. Outside Wine the path is unchanged. The missing-folder check failed with the walk-up taken out.- Launcher installs into generated test games, started with
proton runon a new empty prefix under GE-Proton 11-11, Proton 11.0 and Proton-CachyOS, wrotemodel_dir=Z:\...andrr_model=Z:\...\F\model.wgcm. - Not run on Windows.
The change with its tests is in PR #105: commit 1b024cf, which needs only 677af52 (UnderWine()).
Related: #10.
- Lenguaje dominante
- C++
- Estrellas
- 12
- Forks
- 2
- Merge medio
- 3 h 10 min
- PR fusionados (30 d)
- 171
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de phantoslayer21/wronggpu
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
phantoslayer21/wronggpu#275 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
phantoslayer21/wronggpu#274 ·
Los mantenedores suelen responder en 1 día
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
phantoslayer21/wronggpu#241 ·
Los mantenedores suelen responder en 1 día
-
bug build
Dificultad 2/5 1-3 horas Aptitud para principiantes 74/100
phantoslayer21/wronggpu#234 ·
Los mantenedores suelen responder en 1 día
-
Launcher tests: "an older record: update available" fakes a version newer than the test buildAbiertobug build
Dificultad 2/5 1-3 horas Aptitud para principiantes 80/100
phantoslayer21/wronggpu#233 ·
Los mantenedores suelen responder en 1 día
Todos los issues de phantoslayer21/wronggpu
Issues similares
-
ai_p2
Dificultad 2/5 1-3 horas Aptitud para principiantes 80/100
ClickHouse/ClickHouse#132519 ·
Los mantenedores suelen responder en 1 día
-
[Bug]: VST3 getMidiControllerAssignment reads past midiControllerToParameter for program changeAbierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
juce-framework/JUCE#1810 ·
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 82/100
petercorke/robotics-toolbox-python#952 ·
Los mantenedores suelen responder en 1 día
-
NatronRenderer: a Python error in the script (-t / project script) doesn't change the exit statusAbiertofunc:engine type:bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
NatronGitHub/Natron#1276 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 1/5 1-3 horas Aptitud para principiantes 77/100
Los mantenedores suelen responder en 1 día