Launcher under Wine/Proton writes model paths the game's own prefix can't reach (C: instead of Z:)

Abierto
#49 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
25/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Estancado
Stack tecnológico
cpp
Área
tooling

Línea de trabajo

The issue says the change and tests already exist on the author's fork in commit 51f28a4, with UnderWine() from commit 35077de as a dependency. Before starting, compare those commits with wg_core/util.cpp and install.cpp and coordinate with the author, who offers to open a PR. If work is still needed, run wg_core_tests under Wine and check that game settings use reachable Z: paths while non-Wine paths remain unchanged.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area: launcher area: linux game-compatibility

What happens

On Linux, players run the launcher under Wine, while Steam's Proton runs each game in a Wine prefix of its own. The launcher writes two paths into the game's settings:

  • model_dir (wronggpu.ini);
  • rr_model (wronggpu-rr.ini).

Both are written as C:\users\<user>\AppData\Local\WrongGPU\model... paths of the launcher's own prefix. The game's prefix has a different C:, so Model M and Ray Reconstruction find no model there.

Suggested fix

Under Wine, write those two paths as Z: paths: Z: maps the Linux root in every prefix, so the game reaches the same files.

  • Wine's kernel32 exports wine_get_unix_file_name, which gives the Linux name of a DOS path.
  • It fails when more than the last part of the path doesn't exist yet (the RR data's F\ folder before its first conversion). So convert the deepest folder that exists and append the rest.
  • A model_dir the player set stays as it is.
  • Detecting Wine: GetProcAddress(GetModuleHandleW(L"ntdll.dll"), "wine_get_version") != nullptr.

The core of it, as I tested it (wg_core/util.cpp):

wstring PathForGamePrefix(const wstring& path) {
    if (path.empty() || !UnderWine()) return path;
    using UnixNameFn = char*(CDECL*)(const wchar_t*);
    auto unixName = reinterpret_cast<UnixNameFn>(reinterpret_cast<void*>(
        GetProcAddress(GetModuleHandleW(L"kernel32.dll"), "wine_get_unix_file_name")));
    if (!unixName) return path;
    wstring head = path, tail;
    char* u = nullptr;
    while (!(u = unixName(head.c_str()))) {          // missing folders: walk up, keep the tail
        const size_t cut = head.find_last_of(L"\\/");
        if (cut == wstring::npos || cut < 3) return path;
        tail = head.substr(cut) + tail;
        head.resize(cut);
    }
    wstring z = L"Z:" + FromUtf8(u) + tail;
    HeapFree(GetProcessHeap(), 0, u);                  // Wine allocates it on the process heap
    for (wchar_t& c : z) if (c == L'/') c = L'\\';
    return z;
}

install.cpp then writes model_dir = PathForGamePrefix(ModelBaseDir()) under Wine when the player set none, and RrIniText(PathForGamePrefix(RrDataFile())). Outside Wine nothing changes: the function returns the path unchanged.

How it was tested (synthetic data only)

  • wg_core_tests under GE-Proton 11-11's Wine (llvm-mingw build): the path names the same file, and a path with two missing folders still becomes a Z: path with its tail kept. Outside Wine the path is unchanged. The missing-folder check failed with the walk-up taken out.
  • Launcher installs into generated test games, started with proton run on a new empty prefix under GE-Proton 11-11, Proton 11.0 and Proton-CachyOS, wrote model_dir=Z:\... and rr_model=Z:\...\F\model.wgcm.
  • Not run on Windows.

The change with its tests is in PR #105: commit 1b024cf, which needs only 677af52 (UnderWine()).

Related: #10.

Lenguaje dominante
C++
Estrellas
12
Forks
2
Merge medio
3 h 10 min
PR fusionados (30 d)
171

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de phantoslayer21/wronggpu

Todos los issues de phantoslayer21/wronggpu

Issues similares

Más issues de C++

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.