0.6.6: follow-ups from the k_approx review (#257)
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Aptitud para principiantes
- 35/100
Línea de trabajo
Start with the six follow-ups in this issue and inspect the named shader file, clean/k/dx12/hlsl/k_out.hlsli, plus the preparation, executor, mode-line, frame-note, and release-diagnostics code they refer to. First trace how selected variants are prepared and how runtime options reach Model K; then review each item’s tests and evidence requirements. Done means the six gaps are fixed or documented as requested, with focused tests or committed synthetic-data summaries for the relevant claims.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Follow-ups from the review rounds of #257 (Model K: the k_approx opt-in close approximations a1 and a2). They are tracked here for 0.6.6; none of them changes the default (nothing set) output.
1. Preparation of a selected form with an unsupported root signature
An otherwise valid manifest can declare a selected approximate form (for example k_out_pixel_c__a2) with a root signature the native device does not support. The loader accepts it, the create-time preflight checks only the name and code object, and preparation returns success without loading the shader, so create succeeds and the first launch fails. Make preparation fail for an unsupported signature or an unmatched variant, and test that malformed selected entry. (The same preparation gap is item 2 of #261.)
2. Non-vacuous selection tests
The approximation test never asserts the k_out_color__a2 launch: replacing only that selection with the exact colour kernel would still pass. The executor matrix reads back no output bytes. Assert every expected approximate launch and the absence of its exact counterpart, for buffer and direct frames and for each tag on its own. Compare direct-route frames byte for byte where an exact reference applies.
3. Mode line with a very long options variable
If the runtime options environment variable exceeds the interop parser's 4095-character limit, the front end reports that it ignored the value, while Model K reads the full variable independently and enables the approximation. The mode line can then say "exact". Derive the mode line from the runtime's effective selection, or use one options source, and test the long-value case.
4. Claims without committed records
A comment in clean/k/dx12/hlsl/k_out.hlsli states a one-ULP maximum and a difference rate for six seeds, and the PR description cites a shader-identity record and an executor negative-control record. Neither record is in the repository. Commit constructed-data summaries for these (synthetic inputs only), or qualify the claims.
5. Frame-note threading contract
wg_rt_take_frame_note hands over the same per-context note a frame can write, without synchronization. The executor calls it synchronously after a frame, which is safe, but the contract is not written down. Document that frame calls and note calls on one context must not run concurrently, or synchronize them.
6. The k_fill test option in release builds
The k_fill option fills Model K buffers with a test pattern and is accepted in release builds; it predates #257. Limit it to developer builds, as the other test hooks are, and add it to the release diagnostics check.
- Lenguaje dominante
- C++
- Estrellas
- 12
- Forks
- 2
- Merge medio
- 3 h 10 min
- PR fusionados (30 d)
- 171
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de phantoslayer21/wronggpu
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
phantoslayer21/wronggpu#275 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
phantoslayer21/wronggpu#274 ·
Los mantenedores suelen responder en 1 día
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
phantoslayer21/wronggpu#241 ·
Los mantenedores suelen responder en 1 día
-
bug build
Dificultad 2/5 1-3 horas Aptitud para principiantes 74/100
phantoslayer21/wronggpu#234 ·
Los mantenedores suelen responder en 1 día
-
Launcher tests: "an older record: update available" fakes a version newer than the test buildAbiertobug build
Dificultad 2/5 1-3 horas Aptitud para principiantes 80/100
phantoslayer21/wronggpu#233 ·
Los mantenedores suelen responder en 1 día
Todos los issues de phantoslayer21/wronggpu
Issues similares
-
ai_p2
Dificultad 2/5 1-3 horas Aptitud para principiantes 80/100
ClickHouse/ClickHouse#132519 ·
Los mantenedores suelen responder en 1 día
-
[Bug]: VST3 getMidiControllerAssignment reads past midiControllerToParameter for program changeAbierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
juce-framework/JUCE#1810 ·
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 82/100
petercorke/robotics-toolbox-python#952 ·
Los mantenedores suelen responder en 1 día
-
NatronRenderer: a Python error in the script (-t / project script) doesn't change the exit statusAbiertofunc:engine type:bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
NatronGitHub/Natron#1276 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 1/5 1-3 horas Aptitud para principiantes 77/100
Los mantenedores suelen responder en 1 día