[Bug]: [mutate] Windows: the 5 s minimum per-mutant timeout is shorter than a child boot under Xdebug, so untested mutants are scored as killed
Los mantenedores suelen responder en 5 días
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Aptitud para principiantes
- 30/100
Línea de trabajo
Start in MutationTest::calculateTimeout() and MutationTest::start(), where the per-mutant timeout is computed and the child's arguments and XDEBUG_MODE are set, then in hasFinished(), which maps ProcessTimedOutException to Timeout. The mutation code lives in pestphp/pest-plugin-mutate, which the issue says is where to work. Done means a mutant that no test covers is reported as untested rather than killed, with the fix chosen by the maintainers from the options listed.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
What Happened
On Windows, pest --mutate scores some mutants as killed when no test can kill them, because their child process times out before the covering test has even run.
MutationTest::calculateTimeout() gives each mutant run the initial suite duration plus max(5, 20%):
return (int) ($initialTestSuiteDuration + max(5, $initialTestSuiteDuration * 0.2));
When the targeted test set is small (a single test file, as when mutating one class), the initial suite takes ~2 s, so each child gets ~7 s. On Windows, booting a child Pest process (Laravel app) takes 4 to 7 s on its own, partly because children inherit XDEBUG_MODE=coverage and the --coverage-php=... argument (see the TODO: filter arguments to remove unnecessary stuff (Teamcity, Coverage, etc.) in MutationTest::start()). Some legitimate runs exceed the budget, hasFinished() maps the ProcessTimedOutException to Timeout, and the score counts Timeout as killed.
Expected: a mutant that no test kills is reported as untested, regardless of process start-up time.
How to Reproduce
-
On Windows, with Xdebug, write a test that executes a class but asserts nothing about it:
it('runs the code without checking anything', function () { (new SomeValueObject(120.5, 80.0))->format(); expect(true)->toBeTrue(); }); -
XDEBUG_MODE=coverage php vendor/bin/pest tests/Unit/SanityTest.php --mutate --class='App\Domain\SomeValueObject' --covered-only --no-cache
Result: Mutations: 15 untested, 6 timeout, 0 tested, score 28.57 %. No test can kill any of these 21 mutants, so the expected score is 0 %.
With the minimum raised from 5 to 30 s on Windows (max(PHP_OS_FAMILY === 'Windows' ? 30 : 5, ...)), the same run reports 21 untested, 0 tested, score 0.00 %.
This was measured with the child-launch fix from #1916 applied (otherwise every mutant is scored as killed and this bug is invisible).
Sample Repository
None (private project). The reproduction above only needs any Laravel app with Pest and one class.
Pest Version
3.8.6 (pestphp/pest-plugin-mutate v3.0.5, symfony/process v7.4.8)
PHP Version
8.4.15 ZTS (x64), Xdebug 3.5.3
Operation System
Windows
Notes
Filed here because issues are disabled on pestphp/pest-plugin-mutate.
Related: #1843 (timed-out mutants scored as killed, different root cause: a deadlock) and #1916 (child process fails to launch on Windows, also scored as killed). pestphp/pest-plugin-mutate#45 would make all three visible instead of silent.
Possible fixes, from least to most invasive:
- do not pass coverage arguments/env to the per-mutant children (the existing TODO), which removes most of the start-up cost;
- a higher minimum timeout, or a
--mutate-timeoutoption; - report
Timeoutseparately from kills in the score.
- Lenguaje dominante
- PHP
- Estrellas
- 11.8k
- Forks
- 559
- Merge medio
- 5 d 23 h
- PR fusionados (30 d)
- 24
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de pestphp/pest
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
Los mantenedores suelen responder en 5 días
-
[Bug]: --mutate hides unreadable files, so mutants behind a failed read can never be killedQuizá libre de nuevo Un pull request para esta issue se cerró sin fusionarse. Abiertobug
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
Los mantenedores suelen responder en 5 días
-
[Bug]: [mutate] Windows: @pest-mutate-ignore comments land on line 1 in files with LF line endingsPosiblemente ocupada @webdevsamran la tomó hace 57 días. Abiertobug
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
Los mantenedores suelen responder en 5 días
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 80/100
Los mantenedores suelen responder en 5 días
-
[pest-plugin-browser] Page::waitForLoadState() never sends its message — waitForEvent() is a silent no-opPosiblemente ocupada @asllanmaciel la tomó hace 70 días. Abiertobug
Dificultad 2/5 1-3 horas Aptitud para principiantes 85/100
pestphp/pest#1892 · 2 comentarios ·
Los mantenedores suelen responder en 5 días
Todos los issues de pestphp/pest
Issues similares
-
Group 2 - Data Storage | Tripal DBX | Chado Group 5 - Search | ElasticSearch | Views Priority - Medium
Dificultad 2/5 1-3 horas Aptitud para principiantes 74/100
-
nginx update required due to NGINX2RootPosiblemente ocupada Un pull request vinculado a esta issue está abierto o ya se fusionó. Abierto
Dificultad 1/5 Menos de una hora Aptitud para principiantes 65/100
mailcow/mailcow-dockerized#7668 · 5 comentarios · 2 reacciones ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 77/100
lara-zeus/spatie-translatable#80 ·
Los mantenedores suelen responder en 1 día
-
small
Dificultad 2/5 1-3 horas Aptitud para principiantes 66/100
uiowa/uiowa#10296 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
asyncapi/modelina#2709 · 1 comentario ·
Los mantenedores suelen responder en 1 día