A failed release is retried without backoff

Abierto
  • ¿Algo no está bien?
#578 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
54/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
go
Área
backend

Línea de trabajo

Start by reading the reconciler's watches for custom resources and release Secrets, then trace how failed attempts update the Irreconcilable condition and write release Secrets. Reproduce with WithFailureRollbacks(false) and a chart containing a Service with port 70000; the issue is resolved when repeated failures use backoff instead of immediately requeuing the resource.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

When an install or upgrade keeps failing, for example because the API server rejects one of the rendered resources, the reconciler retries it right away instead of with controller-runtime's backoff. In our case, it retries about every 1.5 seconds for as long as the chart fails, and logs an error and writes to the API server each time.

Two things requeue the custom resource after every failed attempt, and each of them alone keeps the loop going:

  1. The status update. Every failed attempt writes the status of the custom resource, and the reconciler watches the custom resource for any change, including a status change. The status changes even when the error stays the same, because the reconciler sets Irreconcilable to False before each attempt and back to True after it fails, which gives the condition a new lastTransitionTime.
  2. The release Secrets. The custom resource owns its release Secrets, and the reconciler watches them, so the Secret that Helm writes for each failed revision requeues the resource.

This is the problem of #224. Its fixes, #225 and #226, were closed as stale. It also happens with WithFailureRollbacks(false), without rollbacks.

A possible fix is to ignore updates of the custom resource that change only its status, as the reconciler already does for dependent resources, which also covers errors whose message changes between attempts, and to keep the release Secret writes from requeuing the resource.

Steps to reproduce

Reconcile a custom resource with WithFailureRollbacks(false) and a chart that renders a resource the API server rejects, for example a Service with port 70000.

Lenguaje dominante
Go
Estrellas
59
Forks
54
Sin PR fusionados en 30 d

Preparar el entorno

  • Incluye un Dockerfile o un archivo de Docker Compose
  • Sin plantilla de pull request
  • Sin guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de operator-framework/helm-operator-plugins

Todos los issues de operator-framework/helm-operator-plugins

Issues similares

Más issues de Go

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.