UI: party and guild-war messages addressed to the wrong side

Abierto
#3,677 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
48/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
typescript
Área
frontend

Línea de trabajo

Start in apps/client-next/tools/ui-gallery: run the gallery and open the entries reach:party-approval, reach:party-joining, reach:guild-war-result and the party-invitation entry, then read the recipe/fixture that feeds each one. Find the text key and argument order each entry passes and compare with what the receiving side expects. First check whether the wrong strings come from fixture data or from production key selection. Done when all four entries render the correct side's wording.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area: client bug priority: high

Found in a full sweep of the UI gallery (apps/client-next/tools/ui-gallery). Some party and guild-war messages read as if addressed to the wrong side.

Gallery entries:

  • reach:party-approval (party matching, incoming approval on the leader's side): shows "You have successfully joined this party."
  • reach:party-joining: shows "[Reviewer]You [Peer] have joined this party." (both names and "You").
  • reach:guild-war-result: the war-result alarm names our own guild ("[Review Guild]") where the opponent is expected.
  • The "party invitation" entry: "[Seller]has" then "Party application success. Will you accept it?" on a separate line.

To do: for each, read which text key and arguments the native picks for the receiving side, and fix the key or argument order. Some may be fixture data rather than production; check the recipe first.

Lenguaje dominante
Go
Estrellas
97
Forks
61
Merge medio
4 h 14 min
PR fusionados (30 d)
913

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de opensro-dev/opensro

Todos los issues de opensro-dev/opensro

Issues similares

Más issues de Go

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.