Bug and suggested fix.`ReplaceSystemOutWithIOPrint` corrupts syntax when method arguments have bounded or generic return types.
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 2/5
- Tiempo estimado
- 1-3 horas
- Aptitud para principiantes
- 55/100
Línea de trabajo
Start with ReplaceSystemOutWithIOPrint.java and its ReplaceSystemOutWithIOPrintTest.java tests. Run the focused test class, then add the supplied generic method invocation reproducer and check that the transformed output preserves the invocation. Done means the regression test passes without compiler placeholder artifacts.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
I checked out all relevant OpenRewrite repo's, fed the AI with existing recipe name and a very careful description. Antigravity with Vertex / Gemini was then tasked to check and test. .Also to create a ticket for it, using your default template. The result is shown beneath.
What version of OpenRewrite are you using?
- Release 8.9.30
rewrite-maven-plugin: 6.50.0rewrite-migrate-java: 3.49.0- JDK: Java 25 (
Temurin-25.0.4.1+1 LTS)
How are you running OpenRewrite?
Maven plugin (mvn org.openrewrite.maven:rewrite-maven-plugin:6.49.0:run) running the recipe org.openrewrite.java.migrate.io.ReplaceSystemOutWithIOPrint (via org.openrewrite.java.migrate.UpgradeToJava25).
What is the smallest, simplest way to reproduce the problem?
When ReplaceSystemOutWithIOPrint runs on a System.out.println(expr) call where the argument has a generic/bounded return type (such as Jackson's <T extends TreeNode> T readValueAsTree()), JavaTemplate.apply("IO.#{}(#{any()})", ...) fails synthetic parameter type attribution (__p1__).
Here is a ready-to-run regression test to add to ReplaceSystemOutWithIOPrintTest.java:
@Test
void replaceSystemOutPrintlnGenericMethodInvocation() {
rewriteRun(
java(
"""
interface TreeNode {}
interface Parser {
<T extends TreeNode> T readValueAsTree();
}
class Example {
void test(Parser p) {
System.out.println(p.readValueAsTree());
}
}
""",
"""
interface TreeNode {}
interface Parser {
<T extends TreeNode> T readValueAsTree();
}
class Example {
void test(Parser p) {
IO.println(p.readValueAsTree());
}
}
"""
)
);
}
What did you expect to see?
The generic invocation should be preserved cleanly in the transformed output:
class Example {
void test(Parser p) {
IO.println(p.readValueAsTree());
}
}
What did you see instead?
Compiler placeholder artifacts (__P__.<error>) leak directly into the generated source file:
class Example {
void test(Parser p) {
IO.println(__P__.<error> & TreeNode > pg.String & TreeNode>/*__p1__*/p());
}
}
When run against real application code using Jackson (System.out.println(p.readValueAsTree())), the recipe produces:
IO.println(__P__.<error> & com .fasterxml.jackson.core.TreeNode >/*__p1__*/p());
which subsequently causes javac compilation failures (<identifier> expected, illegal start of expression).
What is the full stack trace of any errors you encountered?
org.opentest4j.AssertionFailedError: [Unexpected result in "TreeNode.java":
expected:
IO.println(p.readValueAsTree());
but was:
IO.println(__P__.<error> & TreeNode > pg.String & TreeNode>/*__p1__*/p());
]
at app//org.openrewrite.test.RewriteTest.assertContentEquals(RewriteTest.java:702)
at app//org.openrewrite.test.RewriteTest.rewriteRun(RewriteTest.java:584)
at app//org.openrewrite.test.RewriteTest.rewriteRun(RewriteTest.java:159)
at app//org.openrewrite.test.RewriteTest.rewriteRun(RewriteTest.java:154)
at app//org.openrewrite.java.migrate.io.ReplaceSystemOutWithIOPrintTest.replaceSystemOutPrintlnGenericMethodInvocation(ReplaceSystemOutWithIOPrintTest.java:292)
Are you interested in contributing a fix to OpenRewrite?
Yes! We have already implemented and validated the fix locally.
Root Cause:
In ReplaceSystemOutWithIOPrint.java:
String methodName = m.getName().getSimpleName();
return m.getArguments().isEmpty() ?
JavaTemplate.apply( "IO.#{}()", getCursor(), m.getCoordinates().replace(), methodName ) :
JavaTemplate.apply( "IO.#{}(#{any()})", getCursor(), m.getCoordinates().replace(), methodName, m.getArguments().get( 0 ) );
Re-templating the arguments via JavaTemplate re-evaluates the argument's type through synthetic parameters (__p1__), which breaks on bounded type variables / intersection types.
Proposed Solution:
Since method names (print/println) and signatures are identical between System.out and IO, re-templating arguments is unnecessary. Directly replacing m.getSelect() with an IO identifier leaves the arguments AST untouched:
diff --git a/src/main/java/org/openrewrite/java/migrate/io/ReplaceSystemOutWithIOPrint.java b/src/main/java/org/openrewrite/java/migrate/io/ReplaceSystemOutWithIOPrint.java
index b8960f72..268a731d 100644
--- a/src/main/java/org/openrewrite/java/migrate/io/ReplaceSystemOutWithIOPrint.java
+++ b/src/main/java/org/openrewrite/java/migrate/io/ReplaceSystemOutWithIOPrint.java
@@ -51,13 +56,15 @@ public class ReplaceSystemOutWithIOPrint extends Recipe {
@Override
public J.MethodInvocation visitMethodInvocation(J.MethodInvocation method, ExecutionContext ctx) {
J.MethodInvocation m = super.visitMethodInvocation(method, ctx);
- if (!isSystemOutMethod(m)) {
+ if (!isSystemOutMethod(m) || m.getSelect() == null) {
return m;
}
- String methodName = m.getName().getSimpleName();
- return m.getArguments().isEmpty() ?
- JavaTemplate.apply( "IO.#{}()", getCursor(), m.getCoordinates().replace(), methodName ) :
- JavaTemplate.apply( "IO.#{}(#{any()})", getCursor(), m.getCoordinates().replace(), methodName, m.getArguments().get( 0 ) );
+ JavaType.FullyQualified ioType = JavaType.ShallowClass.build("java.lang.IO");
+ J.Identifier ioIdent = new J.Identifier(Tree.randomId(), m.getSelect().getPrefix(), Markers.EMPTY, emptyList(), "IO", ioType, null);
+ JavaType.Method methodType = m.getMethodType() != null ? m.getMethodType().withDeclaringType(ioType) : null;
+ return m.withSelect(ioIdent).withMethodType(methodType);
}
Testing & Verification performed:
./gradlew test --tests org.openrewrite.java.migrate.io.ReplaceSystemOutWithIOPrintTest: All 12 unit tests pass 100% green (including all existing tests and the new generic reproducer test).- End-to-end application verification: Verified on downstream project under Java 25 (
mvn test-compileandmvn testpass with 0 errors).
- Lenguaje dominante
- Java
- Estrellas
- 160
- Forks
- 133
- Merge medio
- 7 h 49 min
- PR fusionados (30 d)
- 60
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Sin plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de openrewrite/rewrite-migrate-java
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
openrewrite/rewrite-migrate-java#1305 ·
Los mantenedores suelen responder en 1 día
-
bug
Dificultad 3/5 1-2 días Aptitud para principiantes 72/100
openrewrite/rewrite-migrate-java#1319 ·
Los mantenedores suelen responder en 1 día
-
bug
Dificultad 3/5 1-2 días Aptitud para principiantes 55/100
openrewrite/rewrite-migrate-java#1314 ·
Los mantenedores suelen responder en 1 día
-
bug
Dificultad 3/5 1-2 días Aptitud para principiantes 55/100
openrewrite/rewrite-migrate-java#1310 ·
Los mantenedores suelen responder en 1 día
-
bug
Dificultad 4/5 3-5 días Aptitud para principiantes 55/100
openrewrite/rewrite-migrate-java#1307 ·
Los mantenedores suelen responder en 1 día
Todos los issues de openrewrite/rewrite-migrate-java
Issues similares
-
code-maintenance
Dificultad 2/5 1-3 horas Aptitud para principiantes 77/100
Los mantenedores suelen responder en 1 día
-
bug priority: medium Review effort [1-5]: 3 status: needs-triage type: bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
carlos-emr/carlos#5258 ·
Los mantenedores suelen responder en 1 día
-
bug: author create/update with an unknown avatarId returns 404 instead of 400 UNKNOWN_REFERENCEPosiblemente ocupada @Vinu2111 la tomó hoy. Abiertobug
Dificultad 2/5 1-3 horas Aptitud para principiantes 74/100
atomityhq/blog-cms#59 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
PlatformSpecific.hasGreenThreads incorrectly returns false for JDK updates and non-GA versionsAbierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
Los mantenedores suelen responder en 1 día
-
dev/release: verify-release-candidate.sh runs 0 Java tests with Debian's MavenPosiblemente ocupada @kou la tomó hoy. AbiertoType: bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
apache/arrow-adbc#4947 ·
Los mantenedores suelen responder en 1 día