Finished tool call is dropped when a parallel tool's guardrail trips
Los mantenedores suelen responder en 1 día
Ya se ha fusionado un pull request relacionado.
- #5332 de @jbeckwith-oai — fusionado
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Aptitud para principiantes
- 35/100
- Tipo de issue
- Error
- Claridad
- Bien especificado
- Estado de actividad
- Estancado
- Stack tecnológico
- python
- Área
- backend-api-design
Línea de trabajo
The report includes a complete ScriptedModel repro but does not name implementation or test files. Start by running the repro and tracing how parallel tool results are handled when the batch raises; check how run_data, session state, and input-list conversion retain completed calls and preceding reasoning items. Done means the run still raises while completed calls remain available to the next turn; an open pull request is already linked.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Please read this first
- Have you read the docs? Yes.
- Have you searched for related issues? Yes. #4125 and #5318 fixed similar losses, but this case still happens on
main.
Describe the bug
When parallel tool calls run and one of them ends the run with an exception, a call that already finished is dropped from the history.
For example, the model calls create_ticket and send_email together. create_ticket finishes. Then a tool input guardrail on send_email trips, and the run raises ToolInputGuardrailTripwireTriggered. The Session ends up with only the user message, so on the next turn the model creates the ticket again. gpt-5-mini did this 10 of 10 times. With a fix, it was 0 of 10.
The input was accepted and create_ticket really ran, so this isn't speculative work. The guardrails docs keep "already-completed tool call and tool output items" when an output guardrail trips. The same loss also happens with a tool output guardrail, with failure_error_function=None, and when on_tool_end raises.
A fix that worked for me: when the tool batch raises, record the outputs of calls that already finished before re-raising, and keep any reasoning item that comes before a kept call.
Debug information
- Agents SDK version: 0.23.1, and
mainat 71c2da4d - Python 3.12.13, macOS 15.6.1, openai 3.24.0
- Model: none, the repro uses
ScriptedModel - Reproduces on the latest release, every time
Repro steps
import asyncio
from agents import (Agent, RunHooks, Runner, SQLiteSession, ToolGuardrailFunctionOutput,
function_tool, set_tracing_disabled, tool_input_guardrail)
from agents.testing import ScriptedModel, assistant_message, function_call
ticket_created = asyncio.Event()
@function_tool
def create_ticket(order_id: str) -> str:
return f"ticket T-1 for {order_id}" # The ticket now exists.
@tool_input_guardrail
async def block_email(data) -> ToolGuardrailFunctionOutput:
await ticket_created.wait() # Trip only after create_ticket has finished.
return ToolGuardrailFunctionOutput.raise_exception(output_info="blocked")
@function_tool(tool_input_guardrails=[block_email])
def send_email(order_id: str) -> str:
return "sent"
class Hooks(RunHooks):
async def on_tool_end(self, context, agent, tool, result) -> None:
ticket_created.set()
def show(items: list) -> list[str]:
return [f"{i['type']}:{i['call_id']}" if "call_id" in i else i.get("role", "?") for i in items]
async def main() -> None:
calls = [function_call(n, {"order_id": "A1"}, call_id=f"call_{n}") for n in ("send_email", "create_ticket")]
model = ScriptedModel([calls, [assistant_message("ok")]])
agent = Agent(name="support", model=model, tools=[send_email, create_ticket])
session = SQLiteSession("demo")
try:
await Runner.run(agent, "Open a ticket for order A1 and email the customer.", session=session, hooks=Hooks())
except Exception as exc:
print("raised: ", type(exc).__name__, "| run_data.new_items:", len(exc.run_data.new_items))
print("session: ", show(await session.get_items()))
await Runner.run(agent, "Please finish the task.", session=session)
print("next request:", show(model.last_call.input))
set_tracing_disabled(True)
asyncio.run(main())
Output on 0.23.1 and on main:
raised: ToolInputGuardrailTripwireTriggered | run_data.new_items: 0
session: ['user']
next request: ['user', 'user']
Expected behavior
The run still raises, but the finished call stays in the Session, run_data, to_input_list() and to_state(), so the next turn sees it:
raised: ToolInputGuardrailTripwireTriggered | run_data.new_items: 2
session: ['user', 'function_call:call_create_ticket', 'function_call_output:call_create_ticket']
next request: ['user', 'function_call:call_create_ticket', 'function_call_output:call_create_ticket', 'user']
A reasoning item before a kept call has to stay too, or the Responses API rejects the next request.
I ran the repro on 0.23.1 and on main.
- Lenguaje dominante
- Python
- Estrellas
- 30k
- Forks
- 4.9k
- Merge medio
- 9 h 53 min
- PR fusionados (30 d)
- 197
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de openai/openai-agents-python
-
fix(typing): explicitly specialize ToolContext[Any] in ToolFunctionWithToolContextPosiblemente ocupada @AbarnaaSree la tomó hace 2 días. Abierto
Dificultad 1/5 Menos de una hora Aptitud para principiantes 85/100
openai/openai-agents-python#5387 · 3 comentarios ·
Los mantenedores suelen responder en 1 día
-
ShellTool: empty ShellResult(output=[]) fabricates stdout "(no output)" in the model-visible shell_call_output and persisted shell_outputPosiblemente ocupada @AbarnaaSree la tomó hace 2 días. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 77/100
openai/openai-agents-python#5348 · 7 comentarios ·
Los mantenedores suelen responder en 1 día
-
question
Dificultad 2/5 1-3 horas Aptitud para principiantes 35/100
openai/openai-agents-python#5396 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
Invalid handoff arguments end the run, while invalid function tool arguments go back to the modelAbierto
Dificultad 3/5 1-2 días Aptitud para principiantes 62/100
openai/openai-agents-python#5392 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
Dificultad 4/5 3-5 días Aptitud para principiantes 52/100
openai/openai-agents-python#5386 · 5 comentarios ·
Los mantenedores suelen responder en 1 día
Todos los issues de openai/openai-agents-python
Issues similares
-
idxmax/idxmin raise ValueError when a single partition is all-NAPosiblemente ocupada @Jason10191019999 la tomó hoy. Abiertoneeds triage
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
Los mantenedores suelen responder en 3 días
-
Old versions of datamodelsAbiertobug
Dificultad 2/5 1-3 horas Aptitud para principiantes 64/100
-
[BUG]: Windows GUI package of v1.17.0-rc3 has no GTK DLLsPosiblemente ocupada @andrut-ds la tomó hoy. Abiertobug CI/CD Pactus-GUI Windows
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
pactus-project/pactus#2428 ·
Los mantenedores suelen responder en 1 día
-
DiskDataset.reshard() can hang with a zero or negative shard sizePosiblemente ocupada @Programmer-Develops la tomó hoy. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
Los mantenedores suelen responder en 19 días
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 66/100
GNS3/gns3-server#3017 · 1 comentario ·
Los mantenedores suelen responder en 1 día