Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

Write natural echo lines for pack verbs, show and combined clues

Abierto
  • ¿Algo no está bien?
#47 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
54/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
typescript
Área
backend, internationalization

Línea de trabajo

Start with commandLabel in packages/engine/src/commands.ts and the German and English templates in packages/engine/src/messages/de.ts and en.ts. Then review the format definitions and guidance in packages/engine/src/schema.ts, docs/spec/content-pack.md section 7, and the prompt kit before updating the noir pack's pack verbs and version. Done means the echo forms meet the listed cases, tests cover both languages, and the format documentation is updated if echo is added.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area: engine priority: low type: feature

Context

Every accepted command is echoed above its output (block kind echo, built by commandLabel in packages/engine/src/commands.ts from the cmd templates in messages/de.ts and en.ts). Some echo lines read badly, as the first noir playtest round noted:

  • Pack verbs use the label and the object name: »Bezahlen Wirt«, »Zählen Reichsmark«.
  • show uses a colon form: »Zeige Jakobs Zählheft: Kröger«.
  • Combining clues echoes use, although the button says »Kombinieren mit …«: »Benutze Der vergessene Schlüssel mit Zweitschlüssel«. A name that starts with an article keeps its capital letter mid-sentence.

Scope

  • Combining: when both objects of use are clues, echo with a combine template (»Kombiniere A mit B«, "Combine A with B").
  • show and give: a template that reads naturally without grammatical case, chosen here for both languages.
  • Pack verbs: an optional echo template on a pack verb (for example echo: "Bezahl {obj}"). This is an additive format change with spec, schema, JSON Schema and prompt kit updates; without it the current form stays.
  • Decide whether names that start with an article are lower-cased mid-sentence, or whether the authoring guide advises against such names.
  • Use the new template in the noir pack's pack verbs and bump its version.

Acceptance criteria

  • A German speaker reviews the echo lines of the noir walkthrough; none of the forms above remains.
  • Unit tests cover the new templates in German and English.
  • Packs without echo keep their echo lines, apart from the combine and show templates.
  • The spec, schema and prompt kit describe echo if it is added.

References

  • packages/engine/src/commands.ts (commandLabel)
  • packages/engine/src/messages/de.ts
  • packages/engine/src/messages/en.ts
  • packages/engine/src/schema.ts
  • docs/spec/content-pack.md (section 7)
  • packs/letzte-nacht-der-reichsmark/design/CHANGES.md (Playtest round 1)
Lenguaje dominante
TypeScript
Estrellas
0
Forks
0
Merge medio
28 min
PR fusionados (30 d)
2

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de nullthrone/lexvm

Todos los issues de nullthrone/lexvm

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.