fs.globSync() uses process.cwd() when building the root exclude Dirent with withFileTypes
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Aptitud para principiantes
- 76/100
- Tipo de issue
- Error
- Claridad
- Bien especificado
- Estado de actividad
- Activo
- Stack tecnológico
- javascript
- Área
- operating-systems
Línea de trabajo
Comienza en lib/internal/fs/glob.js, en #addSubpattern(), comparando la rama síncrona de withFileTypes y exclude con la ruta asíncrona. Reproduce el problema con el script proporcionado y, después, verifica que el callback de exclude recibe un Dirent para el glob cwd en lugar de process.cwd() y que el directorio queda excluido.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Version
v25.8.2
Platform
Darwin arm64
Subsystem
fs
What steps will reproduce the bug?
const { mkdtempSync, mkdirSync, writeFileSync, globSync } = require('node:fs');
const { tmpdir } = require('node:os');
const { join } = require('node:path');
const { chdir, cwd } = require('node:process');
const base = mkdtempSync(join(tmpdir(), 'glob-root-'));
const ambient = join(base, 'ambient');
const root = join(base, 'root');
mkdirSync(ambient, { recursive: true });
mkdirSync(join(root, 'a'), { recursive: true });
writeFileSync(join(ambient, 'a'), 'shadow-file');
writeFileSync(join(root, 'a', 'real.txt'), 'real');
chdir(ambient);
const seen = [];
const result = globSync('a/**', {
cwd: root,
withFileTypes: true,
exclude: (dirent) => {
seen.push({
name: dirent.name,
parentPath: dirent.parentPath,
isDirectory: dirent.isDirectory(),
isFile: dirent.isFile(),
});
return dirent.isDirectory();
},
});
console.log(JSON.stringify({
processCwd: cwd(),
globCwd: root,
seen,
result: result.map((dirent) => ({
name: dirent.name,
parentPath: dirent.parentPath,
isDirectory: dirent.isDirectory(),
isFile: dirent.isFile(),
})),
}, null, 2));
How often does it reproduce? Is there a required condition?
It reproduces consistently in globSync() when all of the following are true:
withFileTypes: truecwd !== process.cwd()- the pattern goes through the root-entry
#addSubpattern()path (for examplea/**)
If the ambient process.cwd() also contains the same relative path, the callback receives a Dirent for the ambient path instead of the glob cwd path. If the ambient cwd does not contain that path, the root entry can skip the callback entirely because statSync(path) returns null.
The async glob path does not seem affected.
What is the expected behavior? Why is that the expected behavior?
The exclude callback should receive a Dirent describing the candidate entry under options.cwd.
For the repro above, the callback should receive a directory dirent for <globCwd>/a, so dirent.isDirectory() should be true and the result should be an empty array because the callback returns true for directories.
What do you see instead?
The callback receives a Dirent for the ambient process.cwd() path instead:
{
"processCwd": "/tmp/.../ambient",
"globCwd": "/tmp/.../root",
"seen": [
{
"name": "a",
"parentPath": ".",
"isDirectory": false,
"isFile": true
},
{
"name": "real.txt",
"parentPath": "/tmp/.../root/a",
"isDirectory": false,
"isFile": true
}
],
"result": [
{
"name": "a",
"parentPath": "/tmp/.../root",
"isDirectory": true,
"isFile": false
},
{
"name": "real.txt",
"parentPath": "/tmp/.../root/a",
"isDirectory": false,
"isFile": true
}
]
}
So the root a entry is not excluded even though the callback logic is meant to exclude directories.
Additional information
This looks like a sync-only regression in the root-path exclude handling added for #56260 / #57420.
In lib/internal/fs/glob.js, #addSubpattern() computes const fullpath = resolve(this.#root, path), but in the withFileTypes + exclude branch it does:
const stat = this.#cache.statSync(path);
That appears to stat a path relative to process.cwd() instead of options.cwd. The async path already uses await this.#cache.stat(fullpath).
- Lenguaje dominante
- JavaScript
- Estrellas
- 122k
- Forks
- 37.4k
- Merge medio
- 4 d 3 h
- PR fusionados (30 d)
- 279
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de nodejs/node
-
doc
Dificultad 2/5 1-3 horas Aptitud para principiantes 65/100
-
build
Dificultad 1/5 Menos de una hora Aptitud para principiantes 88/100
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 84/100
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 90/100
-
feature request
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
Todos los issues de nodejs/node
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 65/100
-
Theme loads third-party resources on every page (jsdelivr web font, cdnjs Font Awesome) – GDPR Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
docToolchain/docToolchain#1705 ·
-
Timezone select lists one option per character; duplicate "Failed" reason; shared tracker popover id Abiertobug
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
nightscout/nocturne#1414 ·
-
bug v2
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
modelcontextprotocol/inspector#2458 · 1 comentario ·
-
Mend: dependency security vulnerability status: needs triage 🕵️♀️
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
carbon-design-system/ibm-products#9907 ·