consider reintroduce perf-prof support for macOS
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Aptitud para principiantes
- 28/100
- Tipo de issue
- Nueva funcionalidad
- Claridad
- Bastante claro
- Estado de actividad
- Estancado
- Stack tecnológico
- javascript, node.js, rust
- Área
- devtools, performance
Línea de trabajo
Start by reviewing the V8 change that removed perf-prof support and the referenced Node.js v8-perf-maps patch, then compare how macOS jitdump support works in JavaScriptCore and SpiderMonkey. Done means establishing whether Node.js can reintroduce macOS perf-prof support so mixed Rust and JavaScript profiles can be analyzed with samply.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
I'm a maintainer of Rspack, and one of our major challenges is identifying performance bottlenecks in user projects during the build process.
Rspack extensively utilizes node-api, resulting in frequent Rust-JavaScript communication (we support JS loaders and plugins via node-api). Currently, we use cpu-profile to debug JavaScript performance issues and samply for Rust performance issues. However, bottlenecks often span both Rust and JavaScript, making it difficult to analyze using two separate profiling tools.
I recently discovered that samply supports jitdump, which can remap native frames to JavaScript frames, allowing us to analyze performance within a single tool. Unfortunately, Node.js only supports perf-prof on Linux. While debugging on Linux is possible, it's not ideal since most of our internal developers use macOS, and it's impractical to ask users to install Linux solely for generating these profiles.
Upon investigation, I found that perf-prof support was removed in V8 to fix fuzzer tests (https://chromium-review.googlesource.com/c/v8/v8/+/1993969). However, Node.js can support perf-prof with a minor patch. Although the patch isn't perfect, it demonstrates that macOS support is still feasible.
Both JavaScriptCore and SpiderMonkey support jitdump on macOS. I'm wondering if Node.js could reintroduce perf-prof support for macOS, as it would be incredibly useful for profiling JavaScript compiler tools that heavily rely on node-api, such as Rspack, Rolldown, Next.js, SWC and others.
- Lenguaje dominante
- Sin datos de lenguaje
- Estrellas
- 550
- Forks
- 69
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de nodejs/diagnostics
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 65/100
nodejs/diagnostics#648 · 3 comentarios ·
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 20/100
nodejs/diagnostics#690 · 1 reacción ·
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 20/100
nodejs/diagnostics#689 ·
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 25/100
nodejs/diagnostics#688 ·
-
Dificultad 5/5 Más de una semana Aptitud para principiantes 25/100
nodejs/diagnostics#687 ·
Todos los issues de nodejs/diagnostics
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
nightscout/nocturne#1424 ·
-
A claim comment carrying the issue number is silently declined while the workflow reports success Abiertoarea: repo bug perceived difficulty: 2
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
-
impl detach for native Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 65/100
paritytech/zombienet-sdk#591 ·
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
mruangutai/harness#1897 ·