Enabling PGO for Windows releases
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Aptitud para principiantes
- 45/100
- Tipo de issue
- Nueva funcionalidad
- Claridad
- Bastante claro
- Estado de actividad
- Activo
- Stack tecnológico
- node.js, powershell
- Área
- build-system, ci-cd, release
Línea de trabajo
Comienza revisando el borrador del job de Jenkins y el comando de release actuales que se muestran en el issue; después, inspecciona pgo.ps1 y los argumentos de PGO de vcbuild.bat. Confirma, usando el job borrador como referencia de validación, que los builds de release pueden completar los tres pasos de PGO en nightly, mientras que los builds de nightly y canary mantienen la ruta sin PGO.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
I want to start a discussion about enabling PGO for release builds on Windows. Along with LTO (enabled since v26.3), it will further improve Node.js performance on Windows. While LTO builds took 3-3.5 hours initially, recent changes have reduced them to around 2 hours. Enabling PGO will double that time (2 builds are needed plus running workload scripts in between), but overall it will be a bit longer than what LTO took last week. Additionally, I would only enable PGO for release builds, so nightly and canary builds would be unaffected. I feel confident in enabling this because I've already tested it thoroughly in a draft job.
Since Jenkins changes are only visible after they are made, I want to share what I plan to change here before doing it. What we currently have is this:
vcbuild.bat build-release %ARCH% upload
and I would change it to this:
if not exist pgo.ps1 goto :no-pgo
if not "%DISTTYPE%"=="release" goto :no-pgo
echo === PGO Build: Step 1 - Build instrumented binary ===
@REM In first PGO build, make x64 binary to generate profdata (Eventually we want to add ARM64 machines for this)
call vcbuild.bat build-release x64 pgo-generate
if errorlevel 1 exit /b %errorlevel%
echo === PGO Build: Step 2 - Run workload and collect profiles ===
powershell -NoProfile -ExecutionPolicy Bypass -File pgo.ps1 -PgoGenNode Release\node.exe -PhaseOnly
if errorlevel 1 exit /b %errorlevel%
echo --- Cleaning instrumented build ---
git clean -fdx -e node.profdata
if errorlevel 1 exit /b %errorlevel%
echo === PGO Build: Step 3 - Build optimized binary ===
call vcbuild.bat build-release %ARCH% pgo-use upload
exit /b %errorlevel%
:no-pgo
echo === Non-PGO Build ===
vcbuild.bat build-release %ARCH% upload
The script checks whether the Node.js being built has PGO enabled, and if so, it uses it for release builds. This way, if/when we backport PGO to LTS versions, they will pick it up for releases without any further changes in Jenkins.
As I've already stated, I tested this and feel confident about enabling it, but please feel free to share any concerns you might have about these changes.
- Lenguaje dominante
- Jinja
- Estrellas
- 541
- Forks
- 185
- Merge medio
- 2 d 18 h
- PR fusionados (30 d)
- 6
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de nodejs/build
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
-
platform:ppc
Dificultad 1/5 Menos de una hora Aptitud para principiantes 65/100
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
-
incident platform:arm
Dificultad 4/5 3-5 días Aptitud para principiantes 35/100
-
Dificultad 4/5 3-5 días Aptitud para principiantes 45/100
Todos los issues de nodejs/build
Issues similares
-
Name consistency Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
eellak/triplestore#65 · 1 comentario ·
-
litertlm-android AAR ships no consumer ProGuard rules → "mid == null" SIGABRT in minified apps Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
google-ai-edge/LiteRT-LM#3739 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
-
area-Bzlmod team-ExternalDeps type: bug untriaged
Dificultad 2/5 1-3 horas Aptitud para principiantes 65/100
bazelbuild/bazel#31291 · 2 comentarios ·
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
bradcypert/plum#53 ·