Missing tools and adjustments
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Aptitud para principiantes
- 25/100
- Tipo de issue
- Nueva funcionalidad
- Claridad
- Necesita aclaración
- Estado de actividad
- Activo
- Stack tecnológico
- typescript
- Área
- computer-graphics, frontend
Línea de trabajo
Empieza eligiendo una herramienta o un ajuste que no esté marcado y dividiéndolo en un issue enfocado; este issue general enumera varios cambios independientes. Para el trabajo de anotaciones, lee lib/editor/state.ts y buildAnnotationNode(); para los ajustes, inspecciona lib/editor/filters.ts y AdjustPanel. El trabajo relacionado con el texto también implica render.ts y TextOverlay.vue, y done debería definirse mediante el issue enfocado del elemento seleccionado.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Collected while auditing the library against what the editor it replaces offered. Each of these is independent; split one off into its own issue when it gets picked up.
Tools
- Straight line (the arrow tool without the head) — #8
- Eraser, to take back part of a freehand stroke
- Multi-select, so several annotations can be moved or deleted together
- Copy and paste of annotations
- Per-annotation opacity
- Text outline, so a caption stays readable over a busy photo — #23
- Text background, the other way of solving the same problem — #24
- Font family — #25
- Text alignment — #29
- Freehand redaction; elliptical is split out into #28
- Crop to exact pixel dimensions, and a custom aspect ratio input
Adjustments
- Exposure — #7
- Temperature and tint — #7
- Sharpen — #7
- Highlights and shadows — #21
- Vignette — #21
Notes
The annotation types live in lib/editor/state.ts and are rendered in buildAnnotationNode(); a new one needs an entry in the rotate and flip mapping functions there, which is where the coordinate work is. Adjustments are cheaper: a custom filter in lib/editor/filters.ts plus a slider in AdjustPanel.
Text styling was one line here and should not have been: it went out as four
PRs, one per part. I claimed here that alignment needed a text box with a
width behind it, because Konva only honours align on a node that has one.
That was wrong. A block's width is identical whichever way it is aligned, so
the width comparison I based it on could never have shown anything. Measuring
the drawn pixels instead, Konva does align lines inside the block's own width,
and alignment came out the same shape as the other three: a state field, a
render line and a control.
The font is hardcoded in two places that have to agree for the editing overlay
to match what is drawn, render.ts and TextOverlay.vue. Whatever makes it
per-annotation has to thread through both. The trap is the export: if a face
is not loaded when the export canvas renders, Konva falls back silently and
the saved image differs from what was on screen, with no error.
Two things worth knowing from the first batch:
- The line tool was almost free because a two-point annotation shares its coordinate handling with freehand and arrows. An eraser or a freehand redaction will not be: both need new geometry rather than a new case in an existing
switch. - Adjustments that scale channels per pixel should join the existing
tonefilter rather than adding a pass of their own, since each pass is a full walk over the pixels. Sharpen is the exception: it reads its neighbours, so it has to be separate and it has to run last.
Corrected after the second batch, since this note sent me the wrong way:
- Highlights and shadows did not join
tone. That filter only runs when exposure, temperature or tint are set, so folding them in would mean either running it for every image or a condition covering five sliders. They share a pass with each other instead, which is the saving that mattered: they are the same operation weighted to opposite ends. - The vignette cannot join
toneat all. It needs the row width to know where a pixel sits, so it takesPixelImagelike sharpen does rather thanPixelData, and it runs last for the same reason sharpen does: it works on whatever the rest produced, the preset included.
Drafted by an assistant during an audit of the library; not yet reviewed.
- Lenguaje dominante
- TypeScript
- Estrellas
- 2
- Forks
- 0
- Merge medio
- 3 d 5 h
- PR fusionados (30 d)
- 3
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Sin plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de nextcloud-libraries/nextcloud-image-editor
-
Allow saving only as a copyAbiertotype: enhancement
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
-
type: enhancement
Dificultad 4/5 3-5 días Aptitud para principiantes 42/100
-
AI assisted status: triage type: enhancement
Dificultad 3/5 1-2 días Aptitud para principiantes 35/100
-
AI assisted type: enhancement
Dificultad 4/5 3-5 días Aptitud para principiantes 55/100
-
AI assisted type: enhancement
Dificultad 4/5 3-5 días Aptitud para principiantes 48/100
Todos los issues de nextcloud-libraries/nextcloud-image-editor
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 62/100
Merit-Systems/x402scan#1312 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
Los mantenedores suelen responder en 1 día
-
Native Web
Dificultad 1/5 Menos de una hora Aptitud para principiantes 80/100
digitalfabrik/integreat-app#4517 ·
Los mantenedores suelen responder en 2 días
-
TLS guide repeats certs/ in the certificate directoryPosiblemente ocupada @maheshrijal la tomó hoy. Abierto
Dificultad 1/5 Menos de una hora Aptitud para principiantes 92/100
prometheus/docs#3156 ·
Los mantenedores suelen responder en 2 días
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 83/100
medusajs/dtc-starter#90 ·
Los mantenedores suelen responder en 1 día