Report created tasks when create_tasks hits a transport error

Abierto
#414 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
68/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
csharp
Área
api, backend

Línea de trabajo

Read assistant/src/TaskFlow.Mcp/Tools/TaskTools.cs around line 392 and compare create_tasks with the existing transport error handling in update_tasks. Then inspect assistant/src/TaskFlow.Mcp/Tools/JournalTools.cs around lines 194–216 for set_journal_todos. Done when both tools stop after a transport failure and report created items plus remaining items as “not attempted.”

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

bug

Follow-up from #413 (chore: move taskflow-assistant into assistant/), raised during review.

Problem

create_tasks catches only McpException and TaskFlowApiException per item. TaskFlowApiClient does not wrap transport errors, so a timeout (TaskCanceledException) or HttpRequestException on item N escapes the loop. ToolGuard then returns a generic "cannot reach / did not respond" error and the report of the items already created is lost.

Scenario: a 25-item batch times out at item 10. Tasks 1-9 exist in the API, but the tool result lists none of them. The model retries the whole batch and creates duplicates. update_tasks already handles this case with "not attempted" lines, so the two batch tools behave differently. set_journal_todos (JournalTools.cs, around lines 194-216) only catches TaskFlowApiException and has the same gap.

Severity: 🟠 Important. Pre-existing in the imported assistant code, not introduced by #413.

Location

assistant/src/TaskFlow.Mcp/Tools/TaskTools.cs:392 at 3c3e6b4 (permalink)

Suggested approach

Handle transport failures the way update_tasks does: on a transport error, stop the loop, report the items already created, and list the remaining items as "not attempted". Apply the same to set_journal_todos. Deferred from #413 because the assistant code was imported unchanged and feature work there waits for #400.


Created by @nevridge with Claude Code during review of #413

Lenguaje dominante
C#
Estrellas
1
Forks
0
Merge medio
2 h 2 min
PR fusionados (30 d)
98

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de nevridge/TaskFlow

Todos los issues de nevridge/TaskFlow

Issues similares

Más issues de C#

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.