Record migration warnings where they arise

Abierto
  • ¿Algo no está bien?
#63 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
1-2 días
Aptitud para principiantes
45/100
Tipo de issue
Refactorización
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
python
Área
backend

Línea de trabajo

Start with cutover.py, references.py, and cleanup.py, then trace their Jobs and existing warning handling, including the changes in #60. Update operation return values and callers so each pass logs warnings it adds, including on failure; preserve history and deduplication, and revise retry messages. Update the related docstrings and tests for interrupted operations and repeated passes.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

app: scripts status: backlog type: housekeeping
Proposed Changes

Update the migration operations in cutover.py, references.py and cleanup.py to record warnings through MigrationRun.record_warnings() where they arise, and return only counts or other operation results.

Update the cutover, references and cleanup Jobs to log warnings newly added by their own pass, including when a later operation fails. Preserve the run's warning history and deduplication, and update retry messages to point to that history when a warning has already been recorded.

Update callers, docstrings and tests for the revised return values, interrupted operations and repeated passes. This follows up on the warning-handling changes in #60.

Justification

Migration helpers currently use different conventions: some return warnings for their callers to record, while others both record and return them. This adds warning-list plumbing and can lose earlier warnings if later work raises before the list is recorded.

Recording warnings in the operation that produces them gives migration one convention, simplifies callers and preserves already committed warnings when later work fails.

Lenguaje dominante
Python
Estrellas
8
Forks
0
Merge medio
11 h 23 min
PR fusionados (30 d)
24

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de netbox-community/netbox-scripts

Todos los issues de netbox-community/netbox-scripts

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.