Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

Rexml or Nokogiri?

Abierto
  • ¿Algo no está bien?
#137 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
25/100
Tipo de issue
Error
Claridad
Necesita aclaración
Estado de actividad
Estancado
Stack tecnológico
ruby
Área
backend, testing

Línea de trabajo

Start with lib/dbus/xml.rb and spec/bus_and_xml_backend_spec.rb, especially the test case that switches to Nokogiri without restoring the backend. Run the affected specs and inspect the reported failures to establish the supported parser behavior; done means the parser configuration and dependency behavior are decided and the test suite is consistent with that decision.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

PR #87 introduced hard dependency on ReXML. However, the irony is that the Nokogiri is actually preferred and the whole test suite is executed against Nokogiri. On top of that, if Nokogiri is not available, there are ~170 test failures such as:

  2) DBus::Service when a private bus is set up #exists? is true for an existing service
     Failure/Error: @doc = Nokogiri.XML(xml)
     
     NameError:
       uninitialized constant DBus::IntrospectXMLParser::NokogiriParser::Nokogiri
     # ./lib/dbus/xml.rb:81:in `initialize'
     # ./lib/dbus/xml.rb:127:in `new'
     # ./lib/dbus/xml.rb:127:in `parse'
     # ./lib/dbus/proxy_object_factory.rb:33:in `introspect_into'
     # ./lib/dbus/proxy_object.rb:80:in `introspect'
     # ./spec/bus_driver_spec.rb:20:in `block (4 levels) in <top (required)>'
     # ./spec/spec_helper.rb:119:in `with_service_by_activation'
     # ./spec/bus_driver_spec.rb:11:in `block (4 levels) in <top (required)>'
     # ./spec/spec_helper.rb:95:in `block (2 levels) in with_private_bus'
     # ./spec/spec_helper.rb:66:in `with_env'
     # ./spec/spec_helper.rb:94:in `block in with_private_bus'
     # ./spec/spec_helper.rb:66:in `with_env'
     # ./spec/spec_helper.rb:77:in `with_private_bus'
     # ./spec/bus_driver_spec.rb:10:in `block (3 levels) in <top (required)>'

as soon as the BusAndXmlBackendTest tests introspection reading nokogiri test case is executed, because it sets the backend to Nokogiri without reseting it back to the original value:

https://github.com/mvidner/ruby-dbus/blob/b681d697c6539f4438c10b3ec65b1fada3d9f982/spec/bus_and_xml_backend_spec.rb#L31

I'd like to clarify this situation.

If both backends are really equal, then the two test cases should be probably merged into one, where the XML backend is defined by the available package set (or by some env variable) and the test suite should be run twice, once with Nokogiri and the other time with ReXML.

It also is suboptimal to always pull in ReXML gem, when Nokogiri is going to be used. Ideally, there should be no implicit dependency. Maybe the default behavior should be to just gracefully fail if there is no XML parser available. Or only one XML parser could be supported ...

Lenguaje dominante
Ruby
Estrellas
174
Forks
51
Sin PR fusionados en 30 d

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de mvidner/ruby-dbus

Todos los issues de mvidner/ruby-dbus

Issues similares

Más issues de Ruby

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.