editor: LOD_MAP table is missing some LOD models

Abierto
  • ¿Algo no está bien?
#555 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

  • #556 de @Fernando-A-Rocha — cerrado sin fusionar

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
36/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Estancado
Stack tecnológico
lua, python
Área
game-dev

Línea de trabajo

Start with [editor]/editor_main/server/mapEditorScriptingExtension_s.lua at the linked LOD_MAP table, then review client/main.lua’s processCursorLineOfSight() use of processLineOfSight and how it obtains buildingId and buildingLOD. The issue cites model 3589 mapping to LOD 3592 and a Python script that parsed IPL files; use those as starting points to identify missing associations. Done means LOD_MAP includes the missing GTA:SA object-to-LOD mappings.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

enhancement

Which resource(s) have this problem?
editor_main => server => mapEditorScriptingExtension_s.lua

https://github.com/multitheftauto/mtasa-resources/blob/d4c04db009cdd68913fdb47bbc73acd91e63f981/%5Beditor%5D/editor_main/server/mapEditorScriptingExtension_s.lua#L78

Describe the bug
This table is missing certain object model ID => LOD model ID associations.

e.g. ID 3589 (compfukhouse3)'s LOD model is 3592 (LODpfukhouse3)

To Reproduce
The correct LOD model of a world object / building is actually provided in processLineOfSight ("This function casts a ray between two points in the world, and tells you information about the point that was hit, if any."), which is used by the Map Editor in editor_main => client => main.lua @ processCursorLineOfSight() obtaining buildingId and buildingLOD.

Expected behavior
LOD_MAP should include all Object=>LOD model IDs in GTA:SA.

Screenshots

Version
MTA LOD Table [object] = [lodmodel]

Version of Apr 11, 2023 (last change as of submitting this issue)

Additional context
I created a Python script to parse all of the game's IPL files (including the binary IPLs converted to text), and create a dictionary of object model ID => LOD object model ID according to the info in https://gtamods.com/wiki/LOD#GTA_San_Andreas_.26_GTA_IV . I obtained the same LOD_MAP table in this experiment.

I noticed that some LOD Models like LODpfukhouse3 (3592) aren't actually linked by index by any object model in the same IPL file, which is why the script did not find them... Hmm...

EDIT: I understand now, Rockstar separated some LODs into separate binary IPL files :D

Lenguaje dominante
Lua
Estrellas
185
Forks
180
Merge medio
5 d 13 h
PR fusionados (30 d)
2

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de multitheftauto/mtasa-resources

Todos los issues de multitheftauto/mtasa-resources

Issues similares

Más issues de Lua

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.