Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

fix(BACKEND-ROCM): gfx1200 -Werror build break in rocm_paged_attn.hip (unused m_split, g)

Abierto Apto para principiantes
  • ¿Algo no está bien?
#3,254 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
2/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
70/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
cmake, cpp
Área
backend, build-system

Línea de trabajo

Inspecciona src/vt/rocm/rocm_paged_attn.hip alrededor de las líneas 1207 y 1227 y, a continuación, reproduce la compilación de gfx1200 con los comandos de CMake y make proporcionados. Confirma que los diagnósticos de unused-variable se han corregido sin cambiar el comportamiento del operador y verifica que test_backend_cross_device se compile correctamente con ROCm.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Row: -

What's broken

main (current head, via commit b53e20f85e "Implement ROCm split-KV
attention decode (issue #845)", authored 2026-09-17) fails to build for
gfx1200 under the project's -Werror HIP arm. Two unused-variable
diagnostics in src/vt/rocm/rocm_paged_attn.hip:

src/vt/rocm/rocm_paged_attn.hip:1227:11: error: unused variable 'm_split' [-Werror,-Wunused-variable]
    float m_split = -INFINITY;
          ^~~~~~~
src/vt/rocm/rocm_paged_attn.hip:1207:17: error: unused variable 'g' [-Werror,-Wunused-variable]
  const int64_t g = h / (hq / num_kv_heads);
                ^

Compiler: ROCm's bundled Clang 22.0.0 (/opt/rocm/lib/llvm/bin/clang++),
target gfx1200.

How found

Discovered while independently reproducing the operator's gfx1200 toggle
matrix for PR #3036 (KERNEL-QUANT-CIQ-GEMM-ROCM's cooperative-tile WMMA
arms). That PR's own changed files are unaffected — git diff --stat between
the row branch's pre-merge tip and its current head (after merging main)
touches only src/vt/rocm/rocm_grouped_gemm.hip and
tests/vt/test_backend_cross_device.cpp. rocm_paged_attn.hip is untouched
by #3036; the break is inherited purely from the main merge.

git blame on both lines attributes them to b53e20f85e alone.

Impact

Any current gfx1200 build (this row's toggle matrix included) fails before a
single device test can run. Whatever CI runs for this repo does not build
ROCm/HIP (no such check appears on recent PRs, #3036 included), so this
never surfaced there — only a real gfx1200 box building current main
reproduces it.

Repro

git clone https://github.com/mudler/vllm.cpp && cd vllm.cpp
mkdir build-hip && cd build-hip
cmake .. -DVLLM_CPP_ROCM=ON -DCMAKE_HIP_ARCHITECTURES=gfx1200
make -j16 test_backend_cross_device

Host used: isravale, RX 9060 XT (gfx1200), ROCm 7.2.3.

Owed

No row claims this yet. Per AGENTS.md "An issue you do not fix in the same
flow has to say who owns it," this needs either an owning row's Row: line
or a spec's ## Owed entry — filed as - because neither exists yet; needs
triage to pick an owner (most likely folded into BACKEND-ROCM or a fresh
row for the gfx1200 -Werror arm).

FOLLOWING_AGENTS_PROTOCOL

Following-Agents-Protocol: true
AI-Assisted: true
Assisted-by: AGENT:claude-sonnet-5 [Claude Code]

Lenguaje dominante
C++
Estrellas
423
Forks
53
Merge medio
1 d 7 h
PR fusionados (30 d)
382

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de mudler/vllm.cpp

Todos los issues de mudler/vllm.cpp

Issues similares

Más issues de C++

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.