Investigate: vertically coherent disocclusion fill

Abierto
#1 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
25/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
rust

Línea de trabajo

Start with smooth_holes_vertically in src/stereo.rs and the test wide_hole_fill_varies_smoothly_between_rows, then render a case with examples/stereo_from_depth.rs to see the streak. Before writing anything, agree on the replacement fill (push-pull or background-only blur) with the maintainer, because the issue leaves the choice open. Done means a committed before/after crop, a passing unit test on a synthetic depth step with a wide hole, and per-frame cost within the video budget.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Wide disocclusion holes in the right eye still look like a smear. This is what remains after the work already shipped.

Already shipped (not part of this issue)

  • Holes are filled from the farther (background) side, mirroring its texture.
  • smooth_holes_vertically in src/stereo.rs averages filled hole pixels with the filled pixels above and below them, so the fill no longer changes row to row. wide_hole_fill_varies_smoothly_between_rows tests it.
  • Photos refine depth with a joint weighted median plus 1 px foreground dilation (src/depth_refine.rs); video uses the guided filter.

What remains

Holes wider than the smoothing radius still repeat one background column across the hole, which shows as a vertical streak. Replace the mirror-and-smooth fill with a bounded background-only fill, for example push-pull from background pixels or a small 2D blur over hole pixels only (iw3 blur_blend). It must stay cheap enough to run per video frame.

Acceptance criteria

  • A reproducible case (a generated or freely licensed photo plus its depth map, rendered with examples/stereo_from_depth.rs) where the current fill shows a wide-hole streak, committed or linked
  • The new fill removes the streak on that case, shown as a before/after crop
  • Cost per frame stays within the existing video budget; no new model or network dependency
  • A unit test on a synthetic depth step with a wide hole
Lenguaje dominante
Rust
Estrellas
0
Forks
0
Merge medio
3 min
PR fusionados (30 d)
3

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de mrgnw/spatial-maker

Todos los issues de mrgnw/spatial-maker

Issues similares

Más issues de Rust

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.