create can leave a page that nothing on disk names
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Aptitud para principiantes
- 35/100
Línea de trabajo
Start in cmd/create/create.go at reserveOne, then trace CreatePage, os.WriteFile, persistToManifest, and failKeepingPage. Compare the recovery and failure paths and confirm the chosen behavior with maintainers; done means a failed reservation cannot leave an unrecorded page, or provides an exact actionable recovery record.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
create can leave a page in Confluence that nothing on disk names.
In the reserve phase, reserveOne (cmd/create/create.go) calls CreatePage and only then records the new page_id. It records it in one of two places: the file's frontmatter (os.WriteFile) or a pages: entry in markfluence.yaml (persistToManifest). If that write fails, the page already exists. Examples are a read-only .md file, a read-only markfluence.yaml, or a manifest write that gives up after its one retry.
failKeepingPage keeps the id and URL in the command's result, so the run's own output is the only record. A second create makes a second page, because nothing says the first one exists. update cannot pick it up either, because nothing names the page.
This is the one case in create's partial-failure story that update cannot recover from. The other two recover:
- A network failure during publish leaves a stub whose id is already on disk, so
updatefinishes it. - An unreadable attachment fails the same way, after the id is on disk.
Options:
- Check that the destination is writable before
CreatePage. This is cheap, but it races: the check can pass and the write can still fail. - Write first, create second. Reserve a placeholder on disk, create the page, then fill in the id. A failure then leaves a local marker instead of a remote orphan.
- Make the failure loud and actionable. For example, print the exact frontmatter line or manifest entry to add by hand, and give it an exit code a script can recognize.
- Lenguaje dominante
- Go
- Estrellas
- 2
- Forks
- 0
- Merge medio
- 2 h 50 min
- PR fusionados (30 d)
- 52
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de mozilla/markfluence
-
Dificultad 4/5 3-5 días Aptitud para principiantes 55/100
mozilla/markfluence#186 ·
-
Dificultad 5/5 Más de una semana Aptitud para principiantes 35/100
mozilla/markfluence#184 ·
-
bug
Dificultad 3/5 1-2 días Aptitud para principiantes 55/100
mozilla/markfluence#181 · 1 comentario ·
-
bug
Dificultad 5/5 Más de una semana Aptitud para principiantes 48/100
mozilla/markfluence#163 ·
-
enhancement
Dificultad 5/5 Más de una semana Aptitud para principiantes 25/100
mozilla/markfluence#162 ·
Todos los issues de mozilla/markfluence
Issues similares
-
agentic-workflows
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
-
agentic-workflows
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
microsoft/agent-framework-go#1179 ·
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
-
[Bug]: OLLAMA_KEEP_ALIVE="5m" / "24h" crashes Ollama embedding and vision models with ValueError Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
infiniflow/ragflow#20223 · 1 reacción ·
-
bug needs triage pkg/translator/faro
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
open-telemetry/opentelemetry-collector-contrib#51484 · 1 comentario ·