Build pins Microsoft.Graph to exactly 2.25.0 while shipped manifests float: two keys to move together

Abierto
#1,617 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
2/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
55/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
powershell
Área
build-system

Línea de trabajo

Read module/Entra/config/ModuleSettings.json and ModuleMetadata.json, then inspect the corresponding EntraBeta files and the build scripts cited in the issue to confirm how each version key is used. The team must first choose a target version; done means both keys match in all four files and a test catches future drift.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

ToTriage

Follow-up from the discussion in #1611 with @SamErde.

#1570 moved the shipped manifests from RequiredVersion to ModuleVersion, so #1449 is fixed for consumers. The build toolchain still pins Microsoft.Graph.* to exactly 2.25.0 (published 2024-11-21). Since then there have been 23 stable releases, up to 2.41.2.

Where the 2.25.0 lives

Two different keys, in two different files, for each module (Entra and EntraBeta):

key file used as
destinationModuleVersion module/Entra/config/ModuleSettings.json:17 exact version installed and imported at build time: build/Install-Dependencies.ps1:42 and :46, build/Publish-LocalCompatModule.ps1:38 and :43, src/CompatibilityAdapterBuilder.ps1:188
requiredModulesVersion module/Entra/config/ModuleMetadata.json:18 minimum written into the shipped RequiredModules: src/EntraModuleBuilder.ps1:536, src/CompatibilityAdapterBuilder.ps1:540

The EntraBeta copies are at the same lines.

Why it matters
  • Contributors and the pipeline build and test against 2.25.0, while users on the Gallery get 2.41.2 (measured: Save-PSResource with PSResourceGet 1.2.0 and Save-Module with PowerShellGet 2.2.5 both resolve 2.41.2 for Microsoft.Entra.Authentication 1.3.0). So what ships is tested against a version users don't actually get.
  • As @SamErde pointed out, PSResourceGet 1.2.0 doesn't reliably pick the newest version that satisfies a floor. On a feed that orders results differently, a user can end up on 2.25.0 exactly. Raising the floor is the only lever a manifest has, because there is no maximum to exclude a bad release above it.
Proposal

Bump both keys together, in all four files, to the same known good version, and keep them in step from then on. A small test that fails when destinationModuleVersion and requiredModulesVersion differ would prevent them from drifting apart again.

Which target would the team prefer: latest (2.41.2), or a specific version you've already validated? Once that's decided, I'm happy to send the PR.

Lenguaje dominante
PowerShell
Estrellas
218
Forks
48
Métricas de merge de PR
Sin PR fusionados en 30 d

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de microsoftgraph/entra-powershell

Todos los issues de microsoftgraph/entra-powershell

Issues similares

Más issues de Build System

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.