api review feedback Nov 11th, 2026

Abierto
  • ¿Algo no está bien?
#44,062 1 comentario 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

@luizpaulo-antunes ya está trabajando en esto.

Desde el 12/11/2026.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
70/100
Tipo de issue
Documentación
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
markdown, playwright, typescript
Área
documentation

Línea de trabajo

Update the API descriptions in docs/src/api/params.md for screenshot animations, locateOnlyVisible, and conditional retries, plus the locators guide's “Matching only visible elements” section and release notes. Start by reading the linked PRs and the existing documentation sections to confirm the intended behavior. Done when all three documentation requests and the screenshot baseline release note are covered.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

API review items

Playwright 1.66 API review, range v1.65.0..main (head 3b438229c), snapshot 2026-11-11.

1. Screenshots with animations: "disabled" leave scroll-driven animations unchanged

PR #44022, Issue #43986

  • instanceof ScrollTimeline
    https://github.com/microsoft/playwright/pull/44061
  • Docs: The animations option text still says that finite animations are fast-forwarded and infinite animations are canceled. Add to both variants in docs/src/api/params.md that scroll-driven and view-driven animations are left unchanged, and add a release notes line that screenshot baselines of such pages can change.

3. locateOnlyVisible context option

PR #43903, Issue #43855

  • apply auto-visible before nth(), but after has:

  • check that we can opt-out with .visible(false|true|'any')

  • Docs: Add to the option description in docs/src/api/params.md that first(), last() and nth() select the element before the visibility filter applies, with the .visible().first() pattern, and mention the option in the "Matching only visible elements" section of the locators guide.

5. Conditional retries: retries accepts a list of { count, condition }

PR #43929, Issue #43917

  • make sure that TestCase.retries is updated before onTestEnd() is called

  • Docs: State in the "Conditional retries" section and in TestConfig.retries that the condition is matched against the error message with its color codes, unless the code is changed to remove them first. State in the same section that the --retries command line option replaces the list.

Lenguaje dominante
TypeScript
Estrellas
99.7k
Forks
6.8k
Merge medio
16 h 10 min
PR fusionados (30 d)
301

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de microsoft/playwright

Todos los issues de microsoft/playwright

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.