Remote closing connection leads to unhandled exceptions in _sync
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Aptitud para principiantes
- 30/100
Línea de trabajo
Empieza leyendo en matrix_client/client.py la sección alrededor de listen_forever y _sync, y después sigue la solicitud de sync a través de matrix_client/api.py. Reproduce o rastrea la desconexión remota notificada y determina el manejo esperado de las excepciones en los hilos en segundo plano; el issue solo estará terminado cuando ese comportamiento y cualquier orientación para el usuario estén claramente definidos y cubiertos.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
I just wanted to point out, that without an error callback, the current implementation of having listen_forever in a thread created by the library can lead to unhandled exceptions that cannot be intercepted.
Following traceback sometimes occurs during running my currently developed bridge software, which atm. lets matrix clients run with start_listener_thread() - it happens very occasionally. I only get a real palpable error later, when i try to send with one of those clients - so until then it does not get noticed. i can also provide more information, but i think this is a more general issue.
I also should mention, my client was connected via https externally
I am of course rewriting it to handle threading on my own anyway so it is not an issue for me i hope in the future - however documentation should probably point out problems like this to the user, so he can prepare or set a general exception handler, and maybe if you keep a "simple we do the threading" solution, an exception callback for the thread would also be a solution.
from pip:
used package: matrix-client==0.3.2
the error logged:
matrix_client.client [ERROR]: Exception thrown during sync
the traceback:
Traceback (most recent call last):
File "/myproject/directory/lib/python3.5/site-packages/urllib3/connectionpool.py", line 600, in urlopen
chunked=chunked)
File "/myproject/directory/lib/python3.5/site-packages/urllib3/connectionpool.py", line 384, in _make_request
six.raise_from(e, None)
File "<string>", line 2, in raise_from
File "/myproject/directory/lib/python3.5/site-packages/urllib3/connectionpool.py", line 380, in _make_request
httplib_response = conn.getresponse()
File "/usr/lib/python3.5/http/client.py", line 1198, in getresponse
response.begin()
File "/usr/lib/python3.5/http/client.py", line 297, in begin
version, status, reason = self._read_status()
File "/usr/lib/python3.5/http/client.py", line 266, in _read_status
raise RemoteDisconnected("Remote end closed connection without"
http.client.RemoteDisconnected: Remote end closed connection without response
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/myproject/directory/lib/python3.5/site-packages/requests/adapters.py", line 445, in send
timeout=timeout
File "/myproject/directory/lib/python3.5/site-packages/urllib3/connectionpool.py", line 638, in urlopen
_stacktrace=sys.exc_info()[2])
File "/myproject/directory/lib/python3.5/site-packages/urllib3/util/retry.py", line 367, in increment
raise six.reraise(type(error), error, _stacktrace)
File "/myproject/directory/lib/python3.5/site-packages/urllib3/packages/six.py", line 685, in reraise
raise value.with_traceback(tb)
File "/myproject/directory/lib/python3.5/site-packages/urllib3/connectionpool.py", line 600, in urlopen
chunked=chunked)
File "/myproject/directory/lib/python3.5/site-packages/urllib3/connectionpool.py", line 384, in _make_request
six.raise_from(e, None)
File "<string>", line 2, in raise_from
File "/myproject/directory/lib/python3.5/site-packages/urllib3/connectionpool.py", line 380, in _make_request
httplib_response = conn.getresponse()
File "/usr/lib/python3.5/http/client.py", line 1198, in getresponse
response.begin()
File "/usr/lib/python3.5/http/client.py", line 297, in begin
version, status, reason = self._read_status()
File "/usr/lib/python3.5/http/client.py", line 266, in _read_status
raise RemoteDisconnected("Remote end closed connection without"
urllib3.exceptions.ProtocolError: ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response',))
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/myproject/directory/lib/python3.5/site-packages/matrix_client/api.py", line 670, in _send
verify=self.validate_cert
File "/myproject/directory/lib/python3.5/site-packages/requests/sessions.py", line 512, in request
resp = self.send(prep, **send_kwargs)
File "/myproject/directory/lib/python3.5/site-packages/requests/sessions.py", line 622, in send
r = adapter.send(request, **kwargs)
File "/myproject/directory/lib/python3.5/site-packages/requests/adapters.py", line 495, in send
raise ConnectionError(err, request=request)
requests.exceptions.ConnectionError: ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response',))
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/myproject/directory/lib/python3.5/site-packages/matrix_client/client.py", line 473, in listen_forever
self._sync(timeout_ms)
File "/myproject/directory/lib/python3.5/site-packages/matrix_client/client.py", line 555, in _sync
response = self.api.sync(self.sync_token, timeout_ms, filter=self.sync_filter)
File "/myproject/directory/lib/python3.5/site-packages/matrix_client/api.py", line 105, in sync
api_path=MATRIX_V2_API_PATH)
File "/myproject/directory/lib/python3.5/site-packages/matrix_client/api.py", line 673, in _send
raise MatrixHttpLibError(e, method, endpoint)
matrix_client.errors.MatrixHttpLibError: Something went wrong in GET requesting https://myproject.host/_matrix/client/r0/sync: ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response',))
- Lenguaje dominante
- Python
- Estrellas
- 266
- Forks
- 118
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de matrix-org/matrix-python-sdk
-
Archive this repository Abierto
Dificultad 1/5 Menos de una hora Aptitud para principiantes 25/100
matrix-org/matrix-python-sdk#330 · 3 reacciones ·
-
Message Delete Method Abierto
Dificultad 5/5 Más de una semana Aptitud para principiantes 25/100
matrix-org/matrix-python-sdk#326 ·
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 55/100
matrix-org/matrix-python-sdk#324 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 48/100
matrix-org/matrix-python-sdk#323 ·
-
Dificultad 3/5 1-2 días Aptitud para principiantes 35/100
matrix-org/matrix-python-sdk#319 ·
Todos los issues de matrix-org/matrix-python-sdk
Issues similares
-
[Bug] reef-hermes tells me to resume with hermes --resume, which does not work from my shell Abiertoarea: harness bug status: needs-triage
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
Human-Agent-Society/reef#625 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
-
Dificultad 1/5 Menos de una hora Aptitud para principiantes 80/100
learningequality/kolibri#15351 · 2 comentarios ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
-
Name consistency Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
eellak/triplestore#65 · 1 comentario ·