Consolidate shared aspects of MalfunctionManager

Abierto
#2,121 4 comentarios 1 reacción 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
38/100
Tipo de issue
Refactorización
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
java
Área
game-dev

Línea de trabajo

Start from MalfunctionManager and the existing maintenanceParameters record. Trace how read-only data (inspection times, Scope/Part maps) is copied per instance, then extract a MaintenancePlan built once per BuildingSpec from attached Functions, plus the same pattern for VehicleSpec, RobotSpec, and a global EVASuit plan. Check that sharing still supports history events from #1629.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

config large settlement

**Is your improvement request related to a situation? **
In recent issue #1629 the MalfunctionManager was lightly reworked to support the creation of history events. This highlighted that each Malfunction Manager instance holds their own copy of read-only sharable data, e.g. inspection times, maps of Scopes and associated Parts for maintenance. These conceptually represent a Maintenance Plan that can be shared for entities of the same type, e.g. EVASuit, Buildings of the same Spec. This would reduce memory consumption.

Describe solution(s) you desire to see
Convert the existing maintenanceParameters record into a more comprehensive configuration class called MaintenancePlan. The latter would be created for each BuildingSpec according to the Functions attached; replicating the logic already in the Malfunction manager class. The same pattern applied for a plan per VehicleSpec & RobotSpec in addition to a single global one for EVASuit.

Lenguaje dominante
Java
Estrellas
169
Forks
50
Merge medio
22 h 56 min
PR fusionados (30 d)
32

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de mars-sim/mars-sim

Todos los issues de mars-sim/mars-sim

Issues similares

Más issues de Java

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.