Adding filetype icons for more formats

Abierto
#1,696 1 comentario 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
48/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Tranquilo
Stack tecnológico
macos, vim
Área
design, desktop

Línea de trabajo

Empieza revisando los recursos de iconos de tipos de archivo existentes y CONTRIBUTING.md para conocer la plantilla establecida y las directrices sobre marcas registradas; después, inspecciona cómo gestiona la aplicación las asociaciones de archivos en Info.plist. Se considera terminado cuando se hayan añadido iconos correspondientes para .ts y .tsx y se haya resuelto o documentado explícitamente el comportamiento de las asociaciones, incluida la posible colisión MPEG de .ts.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

I've been working with .ts and .tsx files as part of a next.js development. Both of these filetypes have syntax support, but MacVim doesn't come bundled with icons for these filetypes. I was able to generate some on my own and, with a few hacks on the command line, get my own macvim installation to show them in finder, and get finder to use macvim to open them.

I thought about trying to add these icons here to the repo, but wanted to check with the dev team first on a few things:

  1. Is there an established template for these icon files? I just photoshopped these together quickly (matching the font/colors/etc. of existing filetype icons), but if there's a source file I could simply edit and export to the same format you already use, I'd rather do that, and generate assets that match what you already are using
  2. The CONTRIBUTING.md file here looks like it comes from vim directly, but regardless, there's a note in there about "not causing trouble with trademarks" -- I think these files are above board (i.e., they don't use any microsoft design language, just plain TS and TSX text), but want to make sure this is OK

I also know it takes more than just creating some images to get this to work -- namely some changes in the main Info.plist for the app to handle the associations properly -- but will hold on any of that until I get a nod here one way or another.

Finally, .ts is also apparently an extension tied to a standard MPEG video format, and if you have an app like VLC installed, it wants to claim the association instead. Just a possible collision that could result if we wanted the app to try to associate itself with that filetype.

Image Image
Lenguaje dominante
Vim Script
Estrellas
7.9k
Forks
691
Sin PR fusionados en 30 d

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de macvim-dev/macvim

Todos los issues de macvim-dev/macvim

Issues similares

Más issues de Design

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.